From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [RFC 1/1] memremap: devm_memremap_pages has wrong nid Date: Thu, 12 Nov 2015 00:05:01 +0200 Message-ID: <5643BB8D.4080202@plexistor.com> References: <5643B043.3010103@plexistor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel , "linux-nvdimm@lists.01.org" To: Dan Williams Return-path: Received: from mail-wm0-f49.google.com ([74.125.82.49]:34206 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbbKKWFF (ORCPT ); Wed, 11 Nov 2015 17:05:05 -0500 Received: by wmvv187 with SMTP id v187so5737397wmv.1 for ; Wed, 11 Nov 2015 14:05:03 -0800 (PST) In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 11/11/2015 11:46 PM, Dan Williams wrote: > On Wed, Nov 11, 2015 at 1:16 PM, Boaz Harrosh wrote: >> >> The pmem dev as received in devm_memremap_pages() does not have >> its dev->numa_node properly initialized yet. >> >> What I see is that all pmem devices will call arch_add_memory >> with nid==0 regardless of the real nid the memory is actually >> on. Needless to say that after that all the NUMA page and zone >> members (at page->flags) come out wrong. >> >> If I do the below code it will all work properly. >> >> RFC because probably we want to fix dev->numa_node before the >> call to devm_memremap_pages. > > Let's just do that instead. I.e. in the case of NFIT numa node should > already be set, and in the case of the memmap=ss!nn or e820-type-12 we > can set the numa node like this: > > diff --git a/drivers/nvdimm/e820.c b/drivers/nvdimm/e820.c > index 8282db2ef99e..e40df8fedf73 100644 > --- a/drivers/nvdimm/e820.c > +++ b/drivers/nvdimm/e820.c > @@ -48,7 +48,7 @@ static int e820_pmem_probe(struct platform_device *pdev) > memset(&ndr_desc, 0, sizeof(ndr_desc)); > ndr_desc.res = p; > ndr_desc.attr_groups = e820_pmem_region_attribute_groups; > - ndr_desc.numa_node = NUMA_NO_NODE; > + ndr_desc.numa_node = memory_add_physaddr_to_nid(p->start); > set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags); > if (!nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc)) > goto err; > > Thanks for pointing out memory_add_physaddr_to_nid(). I did not know > that existed. > Thanks. Its kind of late here now, please let me test this tomorrow and come back to you, but it sounds good, thanks Boaz