From: Boaz Harrosh <boaz@plexistor.com>
To: Toshi Kani <toshi.kani@hpe.com>, Dan Williams <dan.j.williams@intel.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [RFC 1/1] memremap: devm_memremap_pages has wrong nid
Date: Tue, 17 Nov 2015 15:15:06 +0200 [thread overview]
Message-ID: <564B285A.9060604@plexistor.com> (raw)
In-Reply-To: <1447694386.21443.140.camel@hpe.com>
On 11/16/2015 07:19 PM, Toshi Kani wrote:
<>
>> (Ok and we might have a slight problem with an NFIT only Node, where there
>> is no volatile memory at all)
>
> The NFIT driver sets it to the closest on-line node (i.e. where regular memory
> resides) in this case.
>
This is a real problem then. I know it used to be the same with type-12 pmem
and we had real trouble with it on systems performance. Eventually one of your
patches fixed it.
We should fix this for NFIT, yes specially with ZONE_DEVICE and page support.
It will hurt performance a lot.
Eventually I'll get to it, again when NFIT becomes more relevant to us.
<>
>
> Thanks,
> -Toshi
>
Thanks Toshi
Boaz
prev parent reply other threads:[~2015-11-17 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 21:16 [RFC 1/1] memremap: devm_memremap_pages has wrong nid Boaz Harrosh
2015-11-11 21:46 ` Dan Williams
2015-11-11 22:05 ` Boaz Harrosh
2015-11-12 13:10 ` [PATCH] nvdimm: proper NID in e820_pmem_probe Boaz Harrosh
2015-11-12 13:58 ` Boaz Harrosh
2015-11-12 17:13 ` Dan Williams
2015-11-15 10:08 ` Boaz Harrosh
2015-11-13 16:00 ` [RFC 1/1] memremap: devm_memremap_pages has wrong nid Toshi Kani
2015-11-15 9:17 ` Boaz Harrosh
2015-11-16 17:19 ` Toshi Kani
2015-11-17 13:15 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564B285A.9060604@plexistor.com \
--to=boaz@plexistor.com \
--cc=dan.j.williams@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).