From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay04.alfahosting-server.de ([109.237.142.240]:56255 "EHLO relay04.alfahosting-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbbLCSiW (ORCPT ); Thu, 3 Dec 2015 13:38:22 -0500 Received: from alfa3011.alfahosting-server.de (alfa3011.alfahosting-server.de [109.237.134.14]) by relay01.alfahosting-server.de (Postfix) with ESMTPS id C87C132C140D for ; Thu, 3 Dec 2015 19:38:17 +0100 (CET) Received: from [192.168.1.26] (x4d026359.dyn.telefonica.de [77.2.99.89]) by alfa3011.alfahosting-server.de (Postfix) with ESMTPSA id ABD343EF9635 for ; Thu, 3 Dec 2015 19:38:17 +0100 (CET) From: =?UTF-8?Q?Timo_Schl=c3=bc=c3=9fler?= Subject: Re: [PATCH 1/2] HFSPlus: clear dirty flags on remount read-only References: <565B12CC.6040909@schluessler.org> <1448837441.4582.6.camel@ubuntu-slavad-14.04> Cc: linux-fsdevel@vger.kernel.org Message-ID: <56608C3C.6010803@schluessler.org> Date: Thu, 3 Dec 2015 19:38:52 +0100 MIME-Version: 1.0 In-Reply-To: <1448837441.4582.6.camel@ubuntu-slavad-14.04> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hello Vyacheslav, thank you for your quick reply. On 29.11.2015 23:50, Vyacheslav Dubeyko wrote: > Hi Timo, > > > If you set HFSPLUS_VOL_UNMNT and clear HFSPLUS_VOL_INCNSTNT bits on > operation of remount in READ-ONLY state then you should do opposite > operation on remount in READ-WRITE state. But, as far as I can judge, > you've missed this change. Such modification should be in the same > patch. Of course, I will add this change to the patch. > Are you sure that hfsplus_sync_fs() should be called here? As far as I > can see, sync_filesystem() does it for you. What the reason for second > call? Or do I miss something? I wanted to avoid reordering the original code and also avoid to duplicate the call to sync_filesystem() (as I did in the end int the HFS patch). Now when adding the second change to clear HFSPLUS_VOL_UNMNT and set HFSPLUS_VOL_INCNSTNT on remounting READ-WRITE, the reordering makes perfect sense. > Thanks, > Vyacheslav Dubeyko. > Best regards, Timo Schlüßler