From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay05.alfahosting-server.de ([109.237.142.241]:45714 "EHLO relay05.alfahosting-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbbLCSmG (ORCPT ); Thu, 3 Dec 2015 13:42:06 -0500 Received: from alfa3011.alfahosting-server.de (alfa3011.alfahosting-server.de [109.237.134.14]) by relay01.alfahosting-server.de (Postfix) with ESMTPS id 596A432C1704 for ; Thu, 3 Dec 2015 19:42:02 +0100 (CET) Received: from [192.168.1.26] (x4d026359.dyn.telefonica.de [77.2.99.89]) by alfa3011.alfahosting-server.de (Postfix) with ESMTPSA id 3B7C63EF847E for ; Thu, 3 Dec 2015 19:42:02 +0100 (CET) From: =?UTF-8?Q?Timo_Schl=c3=bc=c3=9fler?= Subject: Re: [PATCH 2/2] HFS: clear dirty flags on remount read-only References: <565B12E5.3090600@schluessler.org> <1448838216.4582.12.camel@ubuntu-slavad-14.04> Cc: linux-fsdevel@vger.kernel.org Message-ID: <56608D1C.30708@schluessler.org> Date: Thu, 3 Dec 2015 19:42:36 +0100 MIME-Version: 1.0 In-Reply-To: <1448838216.4582.12.camel@ubuntu-slavad-14.04> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hello Vyacheslav, On 30.11.2015 00:03, Vyacheslav Dubeyko wrote: > Hi Timo, > > I think that this is the right placement for sync_filesystem() call. > It's much better to have such call in one place. Anyway, you need to set > HFS_SB_ATTRIB_UNMNT and to clear HFS_SB_ATTRIB_INCNSTNT for remount from > READ-WRITE to READ-ONLY state. And vou need to do opposite operation for > remount from READ-ONLY to READ-WRITE state. So, it's much better ti > leave sync_filesystem() call in the same place but to add additional > logic before this call. > > Thanks, > Vyacheslav Dubeyko. > I agree with you and will provide an updated patch for this. Best regards Timo Schlüßler