linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linda Knippers <linda.knippers@hpe.com>
To: vishal@kernel.org, linux-nvdimm@lists.01.org
Cc: Vishal Verma <vishal.l.verma@intel.com>,
	linux-acpi@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH 0/3] Expose known poison in SPA ranges to the block layer
Date: Mon, 21 Dec 2015 16:06:29 -0500	[thread overview]
Message-ID: <567869D5.30801@hpe.com> (raw)
In-Reply-To: <1450603122-7205-1-git-send-email-vishal@kernel.org>

On 12/20/2015 04:18 AM, vishal@kernel.org wrote:
> From: Vishal Verma <vishal.l.verma@intel.com>
> 
> This series does a few things:
> - Retrieve all known poison in the system physical address (SPA) space
>   using ARS (Address Range Scrub) commands to firmware
> - Store this poison in a new 'nd_poison' structure
> - In pmem, consume the poison list and expose the ranges as bad sectors
> 
> This depends on the badblocks series sent out previously[1]
> 
> This was tested using nfit_test to add poison at specific address ranges.
> More testing, specially on NVDIMM-N hardware is much appreciated!

All I can report on my NVDIMM-N hardware is that these patches work
properly when the firmware reports that ARS is not supported.  I
can see the capability query and status for each device. Since
there's no ARS support, the rest of the code gets skipped, at it should.

I'll take a look at the test code too but as for testing on my real
NVDIMM-N hardware, this is probably as far as I can go for a while.

-- ljk
> 
> 
> [1]: https://lists.01.org/pipermail/linux-nvdimm/2015-December/003239.html
> 
> Vishal Verma (3):
>   nfit_test: Enable DSMs for all test NFITs
>   libnvdimm: Add a poison list
>   pmem: Use the poison list to expose badblocks
> 
>  drivers/acpi/nfit.c              | 193 +++++++++++++++++++++++++++++++++++++++
>  drivers/nvdimm/core.c            |  63 +++++++++++++
>  drivers/nvdimm/nd-core.h         |   1 +
>  drivers/nvdimm/nd.h              |   6 ++
>  drivers/nvdimm/pmem.c            | 124 +++++++++++++++++++++++++
>  include/linux/libnvdimm.h        |   2 +
>  tools/testing/nvdimm/test/nfit.c |   9 ++
>  7 files changed, 398 insertions(+)
> 


      parent reply	other threads:[~2015-12-21 21:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20  9:18 [PATCH 0/3] Expose known poison in SPA ranges to the block layer vishal
2015-12-20  9:18 ` [PATCH 1/3] nfit_test: Enable DSMs for all test NFITs vishal
2015-12-20  9:18 ` [PATCH 2/3] libnvdimm: Add a poison list vishal
2015-12-20  9:18 ` [PATCH 3/3] pmem: Use the poison list to expose badblocks vishal
2015-12-20  9:31   ` kbuild test robot
2015-12-21  1:20   ` Dan Williams
2015-12-21 18:50     ` Verma, Vishal L
2015-12-21 19:10       ` Dan Williams
2015-12-23 20:28   ` Dan Williams
2015-12-23 20:32     ` Verma, Vishal L
2015-12-23 20:38       ` Dan Williams
2015-12-21 18:34 ` [PATCH 0/3] Expose known poison in SPA ranges to the block layer Verma, Vishal L
2015-12-21 21:06 ` Linda Knippers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567869D5.30801@hpe.com \
    --to=linda.knippers@hpe.com \
    --cc=dan.j.williams@intel.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=ross.zwisler@linux.intel.com \
    --cc=vishal.l.verma@intel.com \
    --cc=vishal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).