From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sandeen.net ([63.231.237.45]:54177 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626AbcARPSS (ORCPT ); Mon, 18 Jan 2016 10:18:18 -0500 Subject: Re: [PATCH 0/4] quota: add new quotactl Q_XGETQUOTA2 To: Jan Kara References: <568FEA2C.6080708@redhat.com> <20160109072600.GA21636@infradead.org> <20160111132617.GD6262@quack.suse.cz> <5693D33A.5090307@sandeen.net> <20160111162807.GK6262@quack.suse.cz> <5696D27A.9070700@sandeen.net> <20160115093507.GA15950@quack.suse.cz> <56992CD4.6030408@sandeen.net> <20160118103302.GD6850@quack.suse.cz> Cc: Christoph Hellwig , fsdevel , Eric Sandeen , xfs@oss.sgi.com From: Eric Sandeen Message-ID: <569D0238.5060407@sandeen.net> Date: Mon, 18 Jan 2016 09:18:16 -0600 MIME-Version: 1.0 In-Reply-To: <20160118103302.GD6850@quack.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 1/18/16 4:33 AM, Jan Kara wrote: > On Fri 15-01-16 11:31:00, Eric Sandeen wrote: ... >> For a purpose-built interface of "find the next ID" that wouldn't require any >> structure or interface changes... >> >> We could name it Q_GETNEXTQUOTA / Q_XGETNEXTQUOTA to make it explicit about >> the purpose, and document that return behavior. Done & done. ;) >> >> A new grand unified extensible quota call sounds like a great idea, I just >> hate to gate this work on designing a brand-new interface. > > OK, ok. I like Dave's proposal for quotactl2(). So let's leave the unification > for later and implent Q_GETNEXTQUOTA and Q_XGETNEXTQUOTA with the > functionality of your original Q_XGETQUOTA2. Having separate call to get > next ID would save us one new quotactl but OTOH we would need two syscalls > (and quota structure lookups) to report one structure and there are > potentially *lots* of them. Ok, I can re-do it with the new Q_[X]GETNEXTQUOTA names, I've already done the non-xfs one as well, just starting testing on that. With or without the flags argument? Thanks, -Eric