From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com ([209.85.192.178]:34911 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756987AbcA2ViU (ORCPT ); Fri, 29 Jan 2016 16:38:20 -0500 Received: by mail-pf0-f178.google.com with SMTP id 65so48240769pfd.2 for ; Fri, 29 Jan 2016 13:38:20 -0800 (PST) To: linux-fsdevel@vger.kernel.org, "Wilcox, Matthew R" , "ross.zwisler@linux.intel.com" From: Jared Hulbert Subject: DAX: bug in COW no page fault? Message-ID: <56ABDBC7.5030703@gmail.com> Date: Fri, 29 Jan 2016 13:38:15 -0800 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Why isn't this required? diff --git a/fs/dax.c b/fs/dax.c index a7f77e1..30f2abe 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -416,6 +416,7 @@ int __dax_fault(struct vm_area_struct *vma, struct vm_fault error = -EIO; goto out; } + i_mmap_unlock_read(mapping); } return VM_FAULT_LOCKED; }