linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Borisov <kernel@kyup.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>,
	linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org,
	Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] ovl: fix working on distributed fs as lower layer
Date: Thu, 18 Feb 2016 09:56:24 +0200	[thread overview]
Message-ID: <56C57928.2010606@kyup.com> (raw)
In-Reply-To: <145424653619.10827.10119853770850679426.stgit@zurg>



On 01/31/2016 03:22 PM, Konstantin Khlebnikov wrote:
> This adds missing .d_select_inode into alternative dentry_operations.
> 
> Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
> Fixes: 7c03b5d45b8e ("ovl: allow distributed fs as lower layer")
> Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
> ---
>  fs/overlayfs/super.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index e6ae59c7119c..1a354840f262 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -343,6 +343,7 @@ static const struct dentry_operations ovl_dentry_operations = {
>  
>  static const struct dentry_operations ovl_reval_dentry_operations = {
>  	.d_release = ovl_dentry_release,
> +	.d_select_inode = ovl_d_select_inode,
>  	.d_revalidate = ovl_dentry_revalidate,
>  	.d_weak_revalidate = ovl_dentry_weak_revalidate,
>  };

I wish I had seen this patch earlier than
https://marc.info/?l=linux-unionfs&m=145494313009959


Reviewed-by: Nikolay Borisov <kernel@kyup.com>
Tested-by: Nikolay Borisov <kernel@kyup.com>


  reply	other threads:[~2016-02-18  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-31 13:22 [PATCH] ovl: fix working on distributed fs as lower layer Konstantin Khlebnikov
2016-02-18  7:56 ` Nikolay Borisov [this message]
2016-03-02 14:18   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C57928.2010606@kyup.com \
    --to=kernel@kyup.com \
    --cc=koct9i@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).