From: Boaz Harrosh <boaz@plexistor.com>
To: Toshi Kani <toshi.kani@hpe.com>,
dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com
Cc: hch@infradead.org, tytso@mit.edu, adilger.kernel@dilger.ca,
ross.zwisler@linux.intel.com, micah.parrish@hpe.com,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Add alignment check for DAX mount
Date: Mon, 02 May 2016 22:20:21 +0300 [thread overview]
Message-ID: <5727A875.6010003@plexistor.com> (raw)
In-Reply-To: <1462214578-27122-1-git-send-email-toshi.kani@hpe.com>
On 05/02/2016 09:42 PM, Toshi Kani wrote:
> When a partition is not aligned by 4KB, mount -o dax succeeds,
> but any read/write access to the filesystem fails, except for
> metadata update.
>
> Add alignment check to ext4, ext2, and xfs.
>
> v2:
> - Use a helper function via ->direct_access for the check.
> (Christoph Hellwig)
> - Call bdev_direct_access() with sector 0 for the check.
> (Boaz Harrosh)
>
> ---
> Toshi Kani (3):
> 1/3 ext4: Add alignment check for DAX mount
> 2/3 ext2: Add alignment check for DAX mount
> 3/3 xfs: Add alignment check for DAX mount
>
All patches look very good to me, and keep the
internals internal. Thanks Toshi
Review-by: Boaz Harrosh <boaz@plexistor.com>
> ---
> fs/ext2/super.c | 21 +++++++++++++++++++--
> fs/ext4/super.c | 20 ++++++++++++++++++--
> fs/xfs/xfs_super.c | 23 +++++++++++++++++++----
> 3 files changed, 56 insertions(+), 8 deletions(-)
>
prev parent reply other threads:[~2016-05-02 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 18:42 [PATCH v2 0/3] Add alignment check for DAX mount Toshi Kani
2016-05-02 18:42 ` [PATCH v2 1/3] ext4: " Toshi Kani
2016-05-03 7:58 ` Jan Kara
2016-05-03 8:44 ` Christoph Hellwig
2016-05-03 9:00 ` Jan Kara
2016-05-03 14:43 ` Ross Zwisler
2016-05-03 15:41 ` Toshi Kani
2016-05-04 15:42 ` Toshi Kani
2016-05-02 18:42 ` [PATCH v2 2/3] ext2: " Toshi Kani
2016-05-03 8:01 ` Jan Kara
2016-05-02 18:42 ` [PATCH v2 3/3] xfs: " Toshi Kani
2016-05-02 19:50 ` Ross Zwisler
2016-05-02 19:54 ` Toshi Kani
2016-05-04 23:18 ` Dave Chinner
2016-05-04 23:41 ` Toshi Kani
2016-05-05 8:03 ` Jan Kara
2016-05-02 19:20 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5727A875.6010003@plexistor.com \
--to=boaz@plexistor.com \
--cc=adilger.kernel@dilger.ca \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=micah.parrish@hpe.com \
--cc=ross.zwisler@linux.intel.com \
--cc=toshi.kani@hpe.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).