From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Subject: Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: use crc and cp version to
 determine roll-forward recovery
To: Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
References: <20160920025504.72524-1-jaegeuk@kernel.org>
 <20160930171005.GC46477@jaegeuk>
From: Chao Yu <chao@kernel.org>
Message-ID: <5758dbdd-610e-64cf-3cef-44794e5b32b4@kernel.org>
Date: Sat, 1 Oct 2016 08:26:20 +0800
MIME-Version: 1.0
In-Reply-To: <20160930171005.GC46477@jaegeuk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 2016/10/1 1:10, Jaegeuk Kim wrote:
> @@ -1089,6 +1079,9 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
>  	if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
>  		set_ckpt_flags(ckpt, CP_FSCK_FLAG);
>  
> +	/* set this flag to activate crc|cp_ver for recovery */
> +	set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG);

Should let new introduced spinlock cover the flag updating in ("f2fs: introduce
cp_lock to protect updating of ckpt_flags").

Thanks,