What happened to the sb writeback list (aka sync efficiency) fix?

What happened to the sb writeback list (aka sync efficiency) fix?

[Holger Hoffstätte]

Once upon a time there was this fine patch set called
"improve sync efficiency with sb inode wb list" [1]
by Brian Foster, who fixed up the original version by Josef Bacik.

I've been running with this since then and it seems to work flawlessly,
yet it doesn't seem that this ever got merged..does anybody know why?

Waiman Long has been working on something similar with his per-CPU
lists, but those patches naturally collide a bit, so I'm wondering
what's what.

Fwiw the effect of the wb list on systems with many cached inodes is
phenomal; it would be a shame if this went unmerged.

thanks,
Holger

[1] http://thread.gmane.org/gmane.linux.file-systems/103940

Re: What happened to the sb writeback list (aka sync efficiency) fix?

[Brian Foster]

On Mon, Jun 20, 2016 at 01:46:38PM +0000, Holger Hoffst�tte wrote:
> 
> Once upon a time there was this fine patch set called
> "improve sync efficiency with sb inode wb list" [1]
> by Brian Foster, who fixed up the original version by Josef Bacik.
> 
> I've been running with this since then and it seems to work flawlessly,
> yet it doesn't seem that this ever got merged..does anybody know why?
> 
> Waiman Long has been working on something similar with his per-CPU
> lists, but those patches naturally collide a bit, so I'm wondering
> what's what.
> 
> Fwiw the effect of the wb list on systems with many cached inodes is
> phenomal; it would be a shame if this went unmerged.
> 

FWIW, the latest version posted was v7:

http://thread.gmane.org/gmane.linux.file-systems/104078

Thanks for the testing feedback. Unfortunately, I've not really heard
any feedback on getting this merged. I'm not sure the previous
version(s) by Josef and Dave got much traction either. :(

Brian

> thanks,
> Holger
> 
> [1] http://thread.gmane.org/gmane.linux.file-systems/103940
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: What happened to the sb writeback list (aka sync efficiency) fix?

[Holger Hoffstätte]

On 06/20/16 18:43, Brian Foster wrote:
> On Mon, Jun 20, 2016 at 01:46:38PM +0000, Holger Hoffstätte wrote:
>>
>> Once upon a time there was this fine patch set called
>> "improve sync efficiency with sb inode wb list" [1]
>> by Brian Foster, who fixed up the original version by Josef Bacik.
>>
>> I've been running with this since then and it seems to work flawlessly,
>> yet it doesn't seem that this ever got merged..does anybody know why?
>>
>> Waiman Long has been working on something similar with his per-CPU
>> lists, but those patches naturally collide a bit, so I'm wondering
>> what's what.
>>
>> Fwiw the effect of the wb list on systems with many cached inodes is
>> phenomal; it would be a shame if this went unmerged.
>>
> 
> FWIW, the latest version posted was v7:
> 
> http://thread.gmane.org/gmane.linux.file-systems/104078

Ah yes..that was a comment update so I didn't merge it.

> Thanks for the testing feedback. Unfortunately, I've not really heard
> any feedback on getting this merged. I'm not sure the previous
> version(s) by Josef and Dave got much traction either. :(

The early versions by Josef had a lockdep issue, which your version
apparently fixed. I've not had a single problem with it..but that
admittedly doesn't mean anything. At some point I tried merging it
with the per-CPU list patches (for fun :) but that turned out a bit
too hairy for me.

cheers,
Holger

Re: What happened to the sb writeback list (aka sync efficiency) fix?

[Jan Kara]

On Mon 20-06-16 12:43:34, Brian Foster wrote:
> On Mon, Jun 20, 2016 at 01:46:38PM +0000, Holger Hoffst�tte wrote:
> > 
> > Once upon a time there was this fine patch set called
> > "improve sync efficiency with sb inode wb list" [1]
> > by Brian Foster, who fixed up the original version by Josef Bacik.
> > 
> > I've been running with this since then and it seems to work flawlessly,
> > yet it doesn't seem that this ever got merged..does anybody know why?
> > 
> > Waiman Long has been working on something similar with his per-CPU
> > lists, but those patches naturally collide a bit, so I'm wondering
> > what's what.
> > 
> > Fwiw the effect of the wb list on systems with many cached inodes is
> > phenomal; it would be a shame if this went unmerged.
> > 
> 
> FWIW, the latest version posted was v7:
> 
> http://thread.gmane.org/gmane.linux.file-systems/104078
> 
> Thanks for the testing feedback. Unfortunately, I've not really heard
> any feedback on getting this merged. I'm not sure the previous
> version(s) by Josef and Dave got much traction either. :(

Actually it would be a pitty to have this dropped. Please rebase & resend
the patches and send them to AKPM asking him to merge them because Al isn't
replying... That should make things moving.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: What happened to the sb writeback list (aka sync efficiency) fix?

[Brian Foster]

On Tue, Jun 21, 2016 at 02:54:46PM +0200, Jan Kara wrote:
> On Mon 20-06-16 12:43:34, Brian Foster wrote:
> > On Mon, Jun 20, 2016 at 01:46:38PM +0000, Holger Hoffst�tte wrote:
> > > 
> > > Once upon a time there was this fine patch set called
> > > "improve sync efficiency with sb inode wb list" [1]
> > > by Brian Foster, who fixed up the original version by Josef Bacik.
> > > 
> > > I've been running with this since then and it seems to work flawlessly,
> > > yet it doesn't seem that this ever got merged..does anybody know why?
> > > 
> > > Waiman Long has been working on something similar with his per-CPU
> > > lists, but those patches naturally collide a bit, so I'm wondering
> > > what's what.
> > > 
> > > Fwiw the effect of the wb list on systems with many cached inodes is
> > > phenomal; it would be a shame if this went unmerged.
> > > 
> > 
> > FWIW, the latest version posted was v7:
> > 
> > http://thread.gmane.org/gmane.linux.file-systems/104078
> > 
> > Thanks for the testing feedback. Unfortunately, I've not really heard
> > any feedback on getting this merged. I'm not sure the previous
> > version(s) by Josef and Dave got much traction either. :(
> 
> Actually it would be a pitty to have this dropped. Please rebase & resend
> the patches and send them to AKPM asking him to merge them because Al isn't
> replying... That should make things moving.
> 

Sure, it rebases clean so I can post a v8 after I get a chance to run
some regression tests.

Holger,

Care to offer a Tested-by?

Brian

> 								Honza
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: What happened to the sb writeback list (aka sync efficiency) fix?

[Holger Hoffstätte]

On 06/21/16 16:03, Brian Foster wrote:
> On Tue, Jun 21, 2016 at 02:54:46PM +0200, Jan Kara wrote:
>> On Mon 20-06-16 12:43:34, Brian Foster wrote:
>>> On Mon, Jun 20, 2016 at 01:46:38PM +0000, Holger Hoffstätte wrote:
>>>>
>>>> Once upon a time there was this fine patch set called
>>>> "improve sync efficiency with sb inode wb list" [1]
>>>> by Brian Foster, who fixed up the original version by Josef Bacik.
>>>>
>>>> I've been running with this since then and it seems to work flawlessly,
>>>> yet it doesn't seem that this ever got merged..does anybody know why?
>>>>
>>>> Waiman Long has been working on something similar with his per-CPU
>>>> lists, but those patches naturally collide a bit, so I'm wondering
>>>> what's what.
>>>>
>>>> Fwiw the effect of the wb list on systems with many cached inodes is
>>>> phenomal; it would be a shame if this went unmerged.
>>>>
>>>
>>> FWIW, the latest version posted was v7:
>>>
>>> http://thread.gmane.org/gmane.linux.file-systems/104078
>>>
>>> Thanks for the testing feedback. Unfortunately, I've not really heard
>>> any feedback on getting this merged. I'm not sure the previous
>>> version(s) by Josef and Dave got much traction either. :(
>>
>> Actually it would be a pitty to have this dropped. Please rebase & resend
>> the patches and send them to AKPM asking him to merge them because Al isn't
>> replying... That should make things moving.
>>
> 
> Sure, it rebases clean so I can post a v8 after I get a chance to run
> some regression tests.
> 
> Holger,
> 
> Care to offer a Tested-by?

My pleasure:

Tested-by: Holger Hoffstätte <holger.hoffstaette@applied-asynchrony.com>

I did this on my custom 4.4.x++ frankenkernel, but I don't see why it
wouldn't work on mainline.

cheers,
Holger

Re: What happened to the sb writeback list (aka sync efficiency) fix?

[Brian Foster]

On Tue, Jun 21, 2016 at 04:12:17PM +0200, Holger Hoffst�tte wrote:
> On 06/21/16 16:03, Brian Foster wrote:
> > On Tue, Jun 21, 2016 at 02:54:46PM +0200, Jan Kara wrote:
> >> On Mon 20-06-16 12:43:34, Brian Foster wrote:
> >>> On Mon, Jun 20, 2016 at 01:46:38PM +0000, Holger Hoffst�tte wrote:
> >>>>
> >>>> Once upon a time there was this fine patch set called
> >>>> "improve sync efficiency with sb inode wb list" [1]
> >>>> by Brian Foster, who fixed up the original version by Josef Bacik.
> >>>>
> >>>> I've been running with this since then and it seems to work flawlessly,
> >>>> yet it doesn't seem that this ever got merged..does anybody know why?
> >>>>
> >>>> Waiman Long has been working on something similar with his per-CPU
> >>>> lists, but those patches naturally collide a bit, so I'm wondering
> >>>> what's what.
> >>>>
> >>>> Fwiw the effect of the wb list on systems with many cached inodes is
> >>>> phenomal; it would be a shame if this went unmerged.
> >>>>
> >>>
> >>> FWIW, the latest version posted was v7:
> >>>
> >>> http://thread.gmane.org/gmane.linux.file-systems/104078
> >>>
> >>> Thanks for the testing feedback. Unfortunately, I've not really heard
> >>> any feedback on getting this merged. I'm not sure the previous
> >>> version(s) by Josef and Dave got much traction either. :(
> >>
> >> Actually it would be a pitty to have this dropped. Please rebase & resend
> >> the patches and send them to AKPM asking him to merge them because Al isn't
> >> replying... That should make things moving.
> >>
> > 
> > Sure, it rebases clean so I can post a v8 after I get a chance to run
> > some regression tests.
> > 
> > Holger,
> > 
> > Care to offer a Tested-by?
> 
> My pleasure:
> 
> Tested-by: Holger Hoffst�tte <holger.hoffstaette@applied-asynchrony.com>
> 

Should this be "holger.hoffstatte@..." (note the dropped 'e')? I got a
return to sender for the above on my recent post. Probably not worth
resending, but you could reply to the post on-list with an accurate
email and I'll fix it up locally as well...

Brian

> I did this on my custom 4.4.x++ frankenkernel, but I don't see why it
> wouldn't work on mainline.
> 
> cheers,
> Holger
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: What happened to the sb writeback list (aka sync efficiency) fix?

[Holger Hoffstätte]

On 06/22/16 13:42, Brian Foster wrote:
> On Tue, Jun 21, 2016 at 04:12:17PM +0200, Holger Hoffstätte wrote:
>> On 06/21/16 16:03, Brian Foster wrote:
>>> On Tue, Jun 21, 2016 at 02:54:46PM +0200, Jan Kara wrote:
>>>> On Mon 20-06-16 12:43:34, Brian Foster wrote:
>>>>> On Mon, Jun 20, 2016 at 01:46:38PM +0000, Holger Hoffstätte wrote:
>>>>>>
>>>>>> Once upon a time there was this fine patch set called
>>>>>> "improve sync efficiency with sb inode wb list" [1]
>>>>>> by Brian Foster, who fixed up the original version by Josef Bacik.
>>>>>>
>>>>>> I've been running with this since then and it seems to work flawlessly,
>>>>>> yet it doesn't seem that this ever got merged..does anybody know why?
>>>>>>
>>>>>> Waiman Long has been working on something similar with his per-CPU
>>>>>> lists, but those patches naturally collide a bit, so I'm wondering
>>>>>> what's what.
>>>>>>
>>>>>> Fwiw the effect of the wb list on systems with many cached inodes is
>>>>>> phenomal; it would be a shame if this went unmerged.
>>>>>>
>>>>>
>>>>> FWIW, the latest version posted was v7:
>>>>>
>>>>> http://thread.gmane.org/gmane.linux.file-systems/104078
>>>>>
>>>>> Thanks for the testing feedback. Unfortunately, I've not really heard
>>>>> any feedback on getting this merged. I'm not sure the previous
>>>>> version(s) by Josef and Dave got much traction either. :(
>>>>
>>>> Actually it would be a pitty to have this dropped. Please rebase & resend
>>>> the patches and send them to AKPM asking him to merge them because Al isn't
>>>> replying... That should make things moving.
>>>>
>>>
>>> Sure, it rebases clean so I can post a v8 after I get a chance to run
>>> some regression tests.
>>>
>>> Holger,
>>>
>>> Care to offer a Tested-by?
>>
>> My pleasure:
>>
>> Tested-by: Holger Hoffstätte <holger.hoffstaette@applied-asynchrony.com>
> 
> Should this be "holger.hoffstatte@..." (note the dropped 'e')? I got a
> return to sender for the above on my recent post. Probably not worth
> resending, but you could reply to the post on-list with an accurate
> email and I'll fix it up locally as well...

I'm confused, that's all. It should be:

Tested-by: Holger Hoffstätte <holger@applied-asynchrony.com>

Trying to ditch gmail and too many different addresses.
Sorry for the confusion..I made the same mistake somewhere else. :(

Holger