From: jeff.xie@linux.dev
To: "Matthew Wilcox" <willy@infradead.org>
Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com,
vbabka@suse.cz, cl@linux.com, penberg@kernel.org,
rientjes@google.com, roman.gushchin@linux.dev,
42.hyeyoo@gmail.com, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
chensong_2000@189.cn, xiehuan09@gmail.com
Subject: Re: [RFC][PATCH 2/4] mm, slub: implement slub allocate post callback for page_owner
Date: Thu, 09 Nov 2023 15:34:25 +0000 [thread overview]
Message-ID: <58b99c29425dd61130f04b41be14e3609daf5a91@linux.dev> (raw)
In-Reply-To: <ZUznNn42H5vRUF0r@casper.infradead.org>
November 9, 2023 at 10:05 PM, "Matthew Wilcox" <willy@infradead.org> wrote:
>
> On Thu, Nov 09, 2023 at 11:25:19AM +0800, Jeff Xie wrote:
>
> >
> > +#ifdef CONFIG_PAGE_OWNER
> > +static int slab_alloc_post_page_owner(struct folio *folio, struct task_struct *tsk,
> > + void *data, char *kbuf, size_t count)
> > +{
> > + int ret;
> > + struct kmem_cache *kmem_cache = data;
> > +
> > + ret = scnprintf(kbuf, count, "SLAB_PAGE slab_name:%s\n", kmem_cache->name);
> > +
> > + return ret;
> > +}
> > +#endif
> >
>
> Or we could do this typesafely ...
>
> struct slab *slab = folio_slab(folio);
> struct kmem_cache *kmem_cache = slab->slab_cache;
>
> ... and then there's no need to pass in a 'data' to the function.
>
I accidentally replied using my other email (xiehuan09@gmail.com) just now.
Thank you for your advice. Indeed, the "data" didn't serve any purpose here.
--
Jeff Xie
next prev parent reply other threads:[~2023-11-09 15:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 3:25 [RFC][PATCH 0/4] mm, page_owner: make the owner in page owner clearer Jeff Xie
2023-11-09 3:25 ` [RFC][PATCH 1/4] mm, page_owner: add folio allocate post callback for struct page_owner to make the " Jeff Xie
2023-11-09 13:59 ` Matthew Wilcox
2023-11-09 15:25 ` Jeff Xie
2023-11-09 15:36 ` Matthew Wilcox
2023-11-09 16:04 ` jeff.xie
2023-11-09 16:38 ` Matthew Wilcox
2023-11-09 3:25 ` [RFC][PATCH 2/4] mm, slub: implement slub allocate post callback for page_owner Jeff Xie
2023-11-09 14:05 ` Matthew Wilcox
2023-11-09 15:34 ` jeff.xie [this message]
2023-11-09 3:25 ` [RFC][PATCH 3/4] filemap: implement filemap " Jeff Xie
2023-11-09 14:09 ` Matthew Wilcox
2023-11-09 15:43 ` jeff.xie
2023-11-09 15:46 ` Matthew Wilcox
2023-11-09 3:25 ` [RFC][PATCH 4/4] mm/rmap: implement anonmap " Jeff Xie
2023-11-09 14:10 ` Matthew Wilcox
2023-11-09 15:47 ` jeff.xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b99c29425dd61130f04b41be14e3609daf5a91@linux.dev \
--to=jeff.xie@linux.dev \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chensong_2000@189.cn \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=xiehuan09@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).