Re: [PATCH 6/8] zonefs: Add active seq file accounting

[Damien Le Moal <damien.lemoal@opensource.wdc.com>]

On 4/19/22 19:59, Johannes Thumshirn wrote:
> On 18/04/2022 03:12, Damien Le Moal wrote:
>> +/*
>> + * Manage the active zone count. Called with zi->i_truncate_mutex held.
>> + */
>> +static void zonefs_account_active(struct inode *inode)
>> +{
>> +	struct zonefs_sb_info *sbi = ZONEFS_SB(inode->i_sb);
>> +	struct zonefs_inode_info *zi = ZONEFS_I(inode);
>> +
> 
> Nit:	lockdep_assert_held(&zi->i_truncate_mutex);

If I add that, lockdep screams during mount as the inodes mutex is not
held when the zone inodes are initialized and zonefs_account_active()
called. We could add a wrapper function for this, but I did not feel it
was necessary.

> 
>> +	if (zi->i_ztype != ZONEFS_ZTYPE_SEQ)
>> +		return;
>> +
> 
> Otherwise,
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>


-- 
Damien Le Moal
Western Digital Research