From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [RFC][PATCH v3 3/6] encrypted-keys: add key format support Date: Wed, 26 Jan 2011 11:03:11 +0000 Message-ID: <5936.1296039791@redhat.com> References: <1295887497-20198-4-git-send-email-roberto.sassu@polito.it> <1295887497-20198-1-git-send-email-roberto.sassu@polito.it> Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, keyrings@linux-nfs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, jmorris@namei.org, zohar@linux.vnet.ibm.com, safford@watson.ibm.com, ramunno@polito.it, tyhicks@linux.vnet.ibm.com, kirkland@canonical.com To: Roberto Sassu Return-path: In-Reply-To: <1295887497-20198-4-git-send-email-roberto.sassu@polito.it> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Roberto Sassu wrote: > This patch introduces a new parameter, called 'format', that defines the > format of data stored by encrypted keys. The 'default' format identifies > encrypted keys containing only the symmetric key, while other formats can > be defined to support additional information. The 'format' parameter is > written in the datablob produced by commands 'keyctl print' or > 'keyctl pipe' and is integrity protected by the HMAC. Would it make more sense to take key=val pairs where you have the parameter? Then you could have a format=default|foo|whatever argument and you'd leave room for future addition of qualifiers. David