From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Subject: Re: [PATCH] f2fs: no need to create issue_discard_thread if it exists
To: Chao Yu <chao@kernel.org>, <jaegeuk@kernel.org>,
        <yuchao0@huawei.com>, <sylinux@163.com>
References: <1499339134-104480-1-git-send-email-yunlong.song@huawei.com>
 <c76a5045-078b-1018-23f8-ccfaefa6f2b4@kernel.org>
CC: <miaoxie@huawei.com>, <bintian.wang@huawei.com>,
        <linux-fsdevel@vger.kernel.org>,
        <linux-f2fs-devel@lists.sourceforge.net>,
        <linux-kernel@vger.kernel.org>
From: Yunlong Song <yunlong.song@huawei.com>
Message-ID: <595EEBA2.8070406@huawei.com>
Date: Fri, 7 Jul 2017 10:02:10 +0800
MIME-Version: 1.0
In-Reply-To: <c76a5045-078b-1018-23f8-ccfaefa6f2b4@kernel.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

It's fine unless create_discard_cmd_control is used in remount flow in the future.

On 2017/7/6 21:16, Chao Yu wrote:
> Hi Yunlong,
>
> It looks there is no way to create discard thread redundantly,
> so here we don't need to check this?
>
> Thanks,
>
> On 2017/7/6 19:05, Yunlong Song wrote:
>> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
>> ---
>>  fs/f2fs/segment.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 4c246e3..b48d004 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -1417,6 +1417,8 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi)
>>  
>>  	if (SM_I(sbi)->dcc_info) {
>>  		dcc = SM_I(sbi)->dcc_info;
>> +		if (dcc->f2fs_issue_discard)
>> +			return err;
>>  		goto init_thread;
>>  	}
>>  
>>
> .
>


-- 
Thanks,
Yunlong Song