From: David Howells <dhowells@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: dhowells@redhat.com, Marc Dionne <marc.dionne@auristor.com>,
Christian Brauner <christian@brauner.io>,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] afs: Make /afs/@cell and /afs/.@cell symlinks
Date: Tue, 07 Jan 2025 17:56:48 +0000 [thread overview]
Message-ID: <599881.1736272608@warthog.procyon.org.uk> (raw)
In-Reply-To: <20250107152050.GP1977892@ZenIV>
Al Viro <viro@zeniv.linux.org.uk> wrote:
> Just allocate those child dentries and call your afs_lookup_atcell() for them.
> No need to keep that mess in ->lookup() - you are keeping those suckers cached
> now, so...
Actually, I wonder if creating the inodes and dentries for cells and the @cell
symlinks at mount of the dynamic root or when the cells are created is
actually the best way.
It might be better to list all the cells and symlinks in readdir and only
create them on demand in ->lookup(). The cells are kept in their own list on
the network namespace anyway, even if the dynamic root isn't mounted.
David
prev parent reply other threads:[~2025-01-07 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 14:25 [PATCH 0/2] afs: Dynamic root improvements David Howells
2025-01-07 14:25 ` [PATCH 1/2] afs: Make /afs/.<cell> as well /afs/<cell> mountpoints David Howells
2025-01-07 14:25 ` [PATCH 2/2] afs: Make /afs/@cell and /afs/.@cell symlinks David Howells
2025-01-07 15:20 ` Al Viro
2025-01-07 15:36 ` David Howells
2025-01-07 17:56 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599881.1736272608@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=christian@brauner.io \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox