From: Jeff Layton <jlayton@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>,
Chuck Lever <chuck.lever@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kuniyuki Iwashima <kuni1840@gmail.com>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] fs/lock: Cleanup around flock syscall.
Date: Mon, 18 Jul 2022 06:43:11 -0400 [thread overview]
Message-ID: <59be17b0006f5aa866d176b8aedc582023f1d8b3.camel@kernel.org> (raw)
In-Reply-To: <20220717043532.35821-1-kuniyu@amazon.com>
On Sat, 2022-07-16 at 21:35 -0700, Kuniyuki Iwashima wrote:
> The first patch removes allocate-and-free for struct file_lock
> in flock syscall and the second patch rearrange some operations.
>
> Changes:
> v3:
> * Test LOCK_MAND first in patch 2
>
> v2: https://lore.kernel.org/linux-fsdevel/20220716233343.22106-1-kuniyu@amazon.com/
> * Use F_UNLCK in locks_remove_flock() (Chuck Lever)
> * Fix uninitialised error in flock syscall (kernel test robot)
> * Fix error when setting LOCK_NB
> * Split patches not to mix different kinds of optimisations and
> not to miss errors reported by kernel test robot
>
> v1: https://lore.kernel.org/linux-fsdevel/20220716013140.61445-1-kuniyu@amazon.com/
>
>
> Kuniyuki Iwashima (2):
> fs/lock: Don't allocate file_lock in flock_make_lock().
> fs/lock: Rearrange ops in flock syscall.
>
> fs/locks.c | 77 ++++++++++++++++++++----------------------------------
> 1 file changed, 28 insertions(+), 49 deletions(-)
>
This looks good, and I've added it to the branch I feed into linux-next.
If all goes well, I'll plan to ask Linus to pull this in for v5.20.
Since you respun it, I dropped Chuck's Reviewed-by. Chuck, please re-
review if you want me to put that back.
Thanks!
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2022-07-18 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 4:35 [PATCH v3 0/2] fs/lock: Cleanup around flock syscall Kuniyuki Iwashima
2022-07-17 4:35 ` [PATCH v3 1/2] fs/lock: Don't allocate file_lock in flock_make_lock() Kuniyuki Iwashima
2022-07-18 13:54 ` Chuck Lever III
2022-07-17 4:35 ` [PATCH v3 2/2] fs/lock: Rearrange ops in flock syscall Kuniyuki Iwashima
2022-07-18 10:43 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59be17b0006f5aa866d176b8aedc582023f1d8b3.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).