From: zhong jiang <zhongjiang@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <viro@zeniv.linux.org.uk>, <linux-fsdevel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/binfmt_elf: remove the same condition check
Date: Thu, 2 Aug 2018 11:24:19 +0800 [thread overview]
Message-ID: <5B627963.8050608@huawei.com> (raw)
In-Reply-To: <20180802023412.GA25338@bombadil.infradead.org>
On 2018/8/2 10:34, Matthew Wilcox wrote:
> On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote:
>> dump_align is used to double check in a expression. It is redundant.
>> so just remove one of them.
> You're wrong. Functions in C can have side-effects (and this one does).
>
>
Ok, I miss that. Thank you for clarification.
Thanks,
zhong jiang
next prev parent reply other threads:[~2018-08-02 5:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 2:00 [PATCH] fs/binfmt_elf: remove the same condition check zhong jiang
2018-08-02 2:34 ` Matthew Wilcox
2018-08-02 3:24 ` zhong jiang [this message]
2018-08-02 3:04 ` Al Viro
2018-08-02 3:56 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B627963.8050608@huawei.com \
--to=zhongjiang@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).