From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DAED156C6F for ; Tue, 17 Sep 2024 11:31:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726572707; cv=none; b=FLl2iwJQ8RyK/tULTwsk/OD8vtN3UMiHywpndv3s2BUI72JoMyGCZtHKAReami30IDRGAlFeecWqceBlGmppTkwX9GJnhVQIdJ08uLVpBgEgjLuNWC99M88T4QdbO+bNRgMAFHIMBCAs67uEevWJVCFUm4aKx04ZNeSK9jjmoW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726572707; c=relaxed/simple; bh=4bjNKuWWw046PH8j5NUWvAfjfjaVMZDU0UtUhBsJzsA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZvN81ceAA3g/rLamkcvRbSY229wq96I2YzuW+ICHRPN0Vplz4UadAc4aqdwE9iKWUCBgi4YePwyAfbEnxIyNdG3LSPa/Xi8dXXBW9zRWllTXkgaIL/p4cbsWJSFc++hh1gpzBbaOtNvzTPzThkjPvd+xJ8iC7wlCmzVjt5wJCVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ws0Y8SBl; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ws0Y8SBl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726572705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oul+0D/MDGitLa0XxGud62DDDYkyjjPr6iJYhvpm5HA=; b=Ws0Y8SBlro5uhGlKl48YeakpbVfjf+Ll/o3GyprslMZBB27lvSzRor7jCD1bmzcA1WPbbu 6SMZ8MK3hNCam9ItjLlDolgFl4Up83ZpffNS1ZmyJGPnmdylaeXt+kadF6GAUsIkyZr5xL uleCpzIEGSIiMryFC0KrsHdP8dXxJho= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-ALVkXi0bPiCm3CrFucUL0A-1; Tue, 17 Sep 2024 07:31:43 -0400 X-MC-Unique: ALVkXi0bPiCm3CrFucUL0A-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-53654fd283bso2737087e87.3 for ; Tue, 17 Sep 2024 04:31:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726572702; x=1727177502; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=oul+0D/MDGitLa0XxGud62DDDYkyjjPr6iJYhvpm5HA=; b=Jh4mqqyO2p0upxnJaapmOzW2UVpqmZz+SsAeXBx1dn6qiSF0RLloK2SvwLXP5IcfCP 4wTA+vVbiByDEtUjbPXYK/K02nUxU91Xz21m2QQGRdYBOSNoA92nraTQu/kgOjpfgFm+ GMN9EN1WRDPS9xIvNf5QS5PxIKCI6o45JK+Asvo9aetf9AtK9PttxGBY0mjMdr7Bll6N Kki70NZ+8AsJ5ukjLFUTPbbj3zzi8DbwaKaGktw3qS7dxBUY5ca6k7tQNwKswyCQDBIq Ue2VoG1/8WEMiV0R0yolnCyDhb8iyu5VqQh9fbdZUS+L3VDr4oi5bhqJOAloc3ywPqig jNsw== X-Forwarded-Encrypted: i=1; AJvYcCWrvbzAbl5CocFiPN5sDrZSaMW3whW1wuV9Zkw181MGzBEiKkrF9vqaH2FNULMXcAyj69qYDuZK6xpkycwB@vger.kernel.org X-Gm-Message-State: AOJu0YyXtICr7HCJqNHc4mG3mZMiHMio82+bOIRqhTQSoSHPGVgZIzwv 1KGWPG+hHnWGRXlo2ggVAsacFY20gK4TQ2eCCol+S6TbYvb5N/KdVkEkYnWZ9xQglIpE011SCWw g9DRmN4uiRNQOZugSQMqtQlfIW/ik4P33XGYDjlSQ25hd25xs/3/Oidiq9gGXMtI= X-Received: by 2002:a05:6512:1242:b0:533:448f:7632 with SMTP id 2adb3069b0e04-5367feba053mr7554868e87.1.1726572702216; Tue, 17 Sep 2024 04:31:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvGVKtqN3ILBeZBk9xYEyrdcbPUlznGq75QoE8BG0n/NvnMUhaFxW/EXPIZ8zLsf4a5/FruQ== X-Received: by 2002:a05:6512:1242:b0:533:448f:7632 with SMTP id 2adb3069b0e04-5367feba053mr7554843e87.1.1726572701637; Tue, 17 Sep 2024 04:31:41 -0700 (PDT) Received: from [192.168.55.136] (tmo-067-108.customers.d1-online.com. [80.187.67.108]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb949bdsm3535380a12.84.2024.09.17.04.31.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Sep 2024 04:31:40 -0700 (PDT) Message-ID: <5af75d55-f65d-4c3d-be85-402386ece04d@redhat.com> Date: Tue, 17 Sep 2024 13:31:37 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 2/7] x86/mm: Drop page table entry address output from pxd_ERROR() To: Dave Hansen , Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , Ryan Roberts , "Mike Rapoport (IBM)" , Arnd Bergmann , x86@kernel.org, linux-m68k@lists.linux-m68k.org, linux-fsdevel@vger.kernel.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen References: <20240917073117.1531207-1-anshuman.khandual@arm.com> <20240917073117.1531207-3-anshuman.khandual@arm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17.09.24 13:19, Dave Hansen wrote: > On 9/17/24 03:22, David Hildenbrand wrote: >> Not a big fan of all these "bad PTE" thingies ... > > In general? In general, after I learned that pmd_bad() fires on perfectly fine pmd_large() entries, which makes things like pmd_none_or_clear_bad() absolutely dangerous to use in code where we could have THPs ... Consequently, we stopped using them in THP code, so what's the whole point of having them ... > > Or not a big fan of the fact that every architecture has their own > (mostly) copied-and-pasted set? Well, that most certainly as well :) -- Cheers, David / dhildenb