From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55A71C6FA82 for ; Thu, 15 Sep 2022 00:44:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230205AbiIOAoS (ORCPT ); Wed, 14 Sep 2022 20:44:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbiIOAoR (ORCPT ); Wed, 14 Sep 2022 20:44:17 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95E7A82D3F; Wed, 14 Sep 2022 17:44:15 -0700 (PDT) X-UUID: 99caa43e76f04a89a221f1b2456d7d18-20220915 X-CPASD-INFO: 1bfac46bc03741979e5c598da2532c18@erKggZBmZJKPUHWDg3SEcVmWZZNlZVi zo2xVZWCTXViVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBiXoZgUZB3gKSggZdiZg== X-CLOUD-ID: 1bfac46bc03741979e5c598da2532c18 X-CPASD-SUMMARY: SIP:-1,APTIP:-2.0,KEY:0.0,FROMBLOCK:1,OB:2.0,URL:-5,TVAL:168. 0,ESV:0.0,ECOM:-5.0,ML:0.0,FD:0.0,CUTS:170.0,IP:-2.0,MAL:-5.0,PHF:-5.0,PHC:-5 .0,SPF:4.0,EDMS:-5,IPLABEL:-2.0,FROMTO:0,AD:0,FFOB:2.0,CFOB:4.0,SPC:0,SIG:-5, AUF:3,DUF:4777,ACD:80,DCD:80,SL:0,EISP:0,AG:0,CFC:0.855,CFSR:0.036,UAT:0,RAF: 2,IMG:-5.0,DFA:0,DTA:0,IBL:-2.0,ADI:-5,SBL:0,REDM:0,REIP:0,ESB:0,ATTNUM:0,EAF :0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 99caa43e76f04a89a221f1b2456d7d18-20220915 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 99caa43e76f04a89a221f1b2456d7d18-20220915 X-User: sunke@kylinos.cn Received: from [10.8.0.3] [(118.250.49.117)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES128-GCM-SHA256 128/128) with ESMTP id 576423423; Thu, 15 Sep 2022 08:44:46 +0800 Message-ID: <5bccb3b6-4a0f-7c33-f968-71c96816c33c@kylinos.cn> Date: Thu, 15 Sep 2022 08:44:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Ke Sun Subject: Re: [PATCH] mm/filemap: Make folio_put_wait_locked static To: Matthew Wilcox , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, k2ci , linux-fsdevel@vger.kernel.org References: <20220914015836.3193197-1-sunke@kylinos.cn> Content-Language: en-US In-Reply-To: <20220914015836.3193197-1-sunke@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Ping. On 2022/9/14 09:58, Ke Sun wrote: > It's only used in mm/filemap.c, since commit > ("mm/migrate.c: rework migration_entry_wait() to not take a pageref"). > > Make it static. > > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Reported-by: k2ci > Signed-off-by: Ke Sun > --- > include/linux/pagemap.h | 1 - > mm/filemap.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 0178b2040ea3..82880993dd1a 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -1042,7 +1042,6 @@ static inline int > wait_on_page_locked_killable(struct page *page) > return folio_wait_locked_killable(page_folio(page)); > } > -int folio_put_wait_locked(struct folio *folio, int state); > void wait_on_page_writeback(struct page *page); > void folio_wait_writeback(struct folio *folio); > int folio_wait_writeback_killable(struct folio *folio); > diff --git a/mm/filemap.c b/mm/filemap.c > index 15800334147b..ade9b7bfe7fc 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1467,7 +1467,7 @@ EXPORT_SYMBOL(folio_wait_bit_killable); > * > * Return: 0 if the folio was unlocked or -EINTR if interrupted by a > signal. > */ > -int folio_put_wait_locked(struct folio *folio, int state) > +static int folio_put_wait_locked(struct folio *folio, int state) > { > return folio_wait_bit_common(folio, PG_locked, state, DROP); > }