From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fallback19.mail.ru ([185.5.136.251]:40148 "EHLO fallback19.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727965AbeLOE0q (ORCPT ); Fri, 14 Dec 2018 23:26:46 -0500 Subject: Re: [PATCH] fix page_count in ->iomap_migrate_page() To: zhangjun Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Weinberger , "Darrick J . Wong" , Andrew Morton References: <1544766961-3492-1-git-send-email-openzhangj@gmail.com> From: Gao Xiang Message-ID: <5cd9ea0d-4c1c-fd4d-4e29-0ee71ef272a0@mail.ru> Date: Sat, 15 Dec 2018 12:26:25 +0800 MIME-Version: 1.0 In-Reply-To: <1544766961-3492-1-git-send-email-openzhangj@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2018/12/14 13:56, zhangjun wrote: > IOMAP uses PG_private a little different with buffer_head based > filesystem. > It uses it as marker and when set, the page counter is not incremented, > migrate_page_move_mapping() assumes that PG_private indicates a counter > of +1. > so, we have to pass a extra count of -1 to migrate_page_move_mapping() > if the flag is set. > > Signed-off-by: zhangjun > --- I found that it fixed in https://patchwork.kernel.org/patch/10684835/ and has been merged in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=61c6de667263184125d5ca75e894fcad632b0dd3 It seems it has been corrected by Piotr. Thanks, Gao Xiang