linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: chengming.zhou@linux.dev, naohiro.aota@wdc.com, jth@kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev,
	Xiongwei.Song@windriver.com,
	Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [PATCH] zonefs: remove SLAB_MEM_SPREAD flag usage
Date: Mon, 26 Feb 2024 05:33:14 -0800	[thread overview]
Message-ID: <5cdbfed3-62cd-41fd-b71a-5c6b1940ceb6@kernel.org> (raw)
In-Reply-To: <20240224135329.830543-1-chengming.zhou@linux.dev>

On 2024/02/24 5:53, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>  fs/zonefs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index 236a6d88306f..c6a124e8d565 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -1422,7 +1422,7 @@ static int __init zonefs_init_inodecache(void)
>  {
>  	zonefs_inode_cachep = kmem_cache_create("zonefs_inode_cache",
>  			sizeof(struct zonefs_inode_info), 0,
> -			(SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT),
> +			SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
>  			NULL);
>  	if (zonefs_inode_cachep == NULL)
>  		return -ENOMEM;

Looks good, but please rework the commit message as you suggested on the btrfs
list to have more details about this change. Thanks.

-- 
Damien Le Moal
Western Digital Research


  reply	other threads:[~2024-02-26 13:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-24 13:53 [PATCH] zonefs: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-02-26 13:33 ` Damien Le Moal [this message]
2024-02-26 13:44   ` Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cdbfed3-62cd-41fd-b71a-5c6b1940ceb6@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=Xiongwei.Song@windriver.com \
    --cc=chengming.zhou@linux.dev \
    --cc=jth@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=naohiro.aota@wdc.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@suse.cz \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).