From: "Arnd Bergmann" <arnd@arndb.de>
To: syzbot <syzbot+7bb7cd3595533513a9e7@syzkaller.appspotmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
christian.brauner@ubuntu.com,
"Damien Le Moal" <damien.lemoal@opensource.wdc.com>,
jlayton@kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Matthew Wilcox" <willy@infradead.org>
Subject: Re: [syzbot] [hfs?] WARNING in hfs_write_inode
Date: Wed, 04 Jan 2023 15:43:33 +0100 [thread overview]
Message-ID: <5f45bb9a-5e00-48dd-82b0-46b19b1b98a3@app.fastmail.com> (raw)
In-Reply-To: <000000000000dbce4e05f170f289@google.com>
On Wed, Jan 4, 2023, at 15:24, syzbot wrote:
> The issue was bisected to:
>
> commit 55d1cbbbb29e6656c662ee8f73ba1fc4777532eb
> Author: Arnd Bergmann <arnd@arndb.de>
> Date: Tue Nov 9 02:35:04 2021 +0000
>
> hfs/hfsplus: use WARN_ON for sanity check
>
My patch was a mechanical conversion from '/* panic? */'
to 'WARN_ON()' to work around a compiler warning,
and the previous code had been in there since the
2004 HFS rewrite by Roman Zippel.
I know nothing about what this function actually does,
so my best answer is that we could revert my patch
and use pr_debug() instead of WARN_ON() for all of these.
Arnd
next prev parent reply other threads:[~2023-01-04 14:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:24 [syzbot] [hfs?] WARNING in hfs_write_inode syzbot
2023-01-04 14:43 ` Arnd Bergmann [this message]
2023-01-04 19:06 ` Linus Torvalds
2023-01-04 22:33 ` Arnd Bergmann
2023-01-04 22:42 ` John Paul Adrian Glaubitz
2023-01-05 0:36 ` Viacheslav Dubeyko
2023-01-05 4:37 ` Viacheslav Dubeyko
2023-01-05 15:46 ` Matthew Wilcox
2023-01-05 16:45 ` Viacheslav Dubeyko
2023-07-20 15:27 ` Dmitry Vyukov
2023-07-20 17:30 ` Matthew Wilcox
2023-07-20 17:50 ` John Paul Adrian Glaubitz
2023-07-20 17:59 ` Matthew Wilcox
2023-07-20 18:27 ` Jeff Layton
2023-07-20 22:20 ` Dave Chinner
2023-07-21 1:03 ` Finn Thain
2023-07-21 1:11 ` Matthew Wilcox
2023-07-21 1:25 ` Michael Schmitz
2023-07-21 1:45 ` Finn Thain
2023-07-21 6:42 ` Kirsten Bromilow
2023-07-21 8:14 ` Finn Thain
2023-07-21 13:10 ` Theodore Ts'o
2023-07-20 21:38 ` Jeffrey Walton
2023-07-20 22:37 ` Matthew Wilcox
2023-07-20 22:53 ` Linus Torvalds
2023-07-21 1:28 ` Mike Hosken
2023-07-20 17:56 ` John Paul Adrian Glaubitz
2023-07-20 19:05 ` Michael Schmitz
2023-07-21 5:07 ` John Paul Adrian Glaubitz
2023-07-21 5:40 ` Eric W. Biederman
2023-01-05 21:34 ` Michael Schmitz
2023-01-05 21:53 ` Linus Torvalds
2023-01-05 23:46 ` Michael Schmitz
2023-01-06 7:09 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f45bb9a-5e00-48dd-82b0-46b19b1b98a3@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+7bb7cd3595533513a9e7@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).