From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: "Markus.Elfring@web.de" <Markus.Elfring@web.de>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Cc: "darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"jth@kernel.org" <jth@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hare@suse.de" <hare@suse.de>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH v9 1/2] fs: New zonefs file system
Date: Wed, 29 Jan 2020 04:13:42 +0000 [thread overview]
Message-ID: <5fe2d31c2f798b0768eec3ebc35bc973bc07ba1c.camel@wdc.com> (raw)
In-Reply-To: <23bf669d-b75f-ed94-478d-06bddd357919@web.de>
On Tue, 2020-01-28 at 16:34 +0100, Markus Elfring wrote:
> …
> > +++ b/fs/zonefs/super.c
> …
> > +out:
> > + kunmap(page);
> > +out_free:
> > + __free_page(page);
>
> Would you like to reconsider your name selection for such labels?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b0be0eff1a5ab77d588b76bd8b1c92d5d17b3f73#n460
>
> Change possibility:
>
> +unmap:
> + kunmap(page);
> +free_page:
> + __free_page(page);
>
Fixed. Thanks !
>
> Regards,
> Markus
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2020-01-29 4:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 15:34 [PATCH v9 1/2] fs: New zonefs file system Markus Elfring
2020-01-29 4:13 ` Damien Le Moal [this message]
2020-01-29 8:20 ` [v9 " Markus Elfring
2020-01-29 8:24 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2020-01-28 16:24 [PATCH v9 " Markus Elfring
2020-01-29 4:14 ` Damien Le Moal
2020-01-27 12:49 Markus Elfring
2020-01-28 1:26 ` Damien Le Moal
2020-01-28 1:28 ` Linus Torvalds
2020-01-28 1:34 ` Damien Le Moal
2020-01-27 10:05 [PATCH v9 0/2] " Damien Le Moal
2020-01-27 10:05 ` [PATCH v9 1/2] fs: " Damien Le Moal
2020-01-28 17:46 ` Darrick J. Wong
2020-01-29 13:06 ` Damien Le Moal
2020-01-29 21:33 ` Dave Chinner
2020-01-30 3:00 ` Damien Le Moal
2020-01-30 22:59 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fe2d31c2f798b0768eec3ebc35bc973bc07ba1c.camel@wdc.com \
--to=damien.lemoal@wdc.com \
--cc=Markus.Elfring@web.de \
--cc=Naohiro.Aota@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=hare@suse.de \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).