linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
To: reiser@namesys.com, reiserfs-dev@namesys.com
Cc: reiserfs-list@namesys.com, linux-fsdevel@vger.kernel.org
Subject: [PATCH] reiserfs:fix journaling issue regarding fsync()
Date: Tue, 20 Jun 2006 17:43:11 +0900	[thread overview]
Message-ID: <6.0.0.20.2.20060620153929.040f0750@172.19.0.2> (raw)

Hi,

  When write() extends a file(i_size is increased) and fsync() is
called, change of inode must be written to journaling area
through fsync().
But,currently the i_trans_id is not correctly updated when i_size
is increased. So fsync() does not kick the journal writer.

Following patch fix this bug.

  Signed-off-by :Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>

diff -Nru linux-2.6.17/fs/reiserfs/super.c linux-2.6.17_fix/fs/reiserfs/super.c
--- linux-2.6.17/fs/reiserfs/super.c	2006-06-18 10:49:35.000000000 +0900
+++ linux-2.6.17_fix/fs/reiserfs/super.c	2006-06-20 14:38:28.000000000 +0900
@@ -558,6 +558,7 @@
  		reiserfs_write_unlock(inode->i_sb);
  		return;
  	}
+	reiserfs_update_inode_transaction(inode);
  	reiserfs_update_sd(&th, inode);
  	journal_end(&th, inode->i_sb, 1);
  	reiserfs_write_unlock(inode->i_sb);


Thanks, 


             reply	other threads:[~2006-06-20  8:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-20  8:43 Hisashi Hifumi [this message]
2006-06-23 10:15 ` [PATCH] reiserfs:fix journaling issue regarding fsync() Vladimir V. Saveliev
2006-06-23 15:53   ` Hans Reiser
2006-06-26  4:39   ` Hisashi Hifumi
2006-06-30  0:47 ` Chris Mason
2006-06-30  1:36   ` Hisashi Hifumi
2006-06-30 12:24     ` Chris Mason
2006-06-30 22:59       ` Hisashi Hifumi
2006-07-01 19:34         ` Chris Mason
2006-07-02 15:34           ` Hans Reiser
2006-07-03  1:31             ` Hisashi Hifumi
2006-07-03  1:36               ` Andrew Morton
2006-07-03  2:03                 ` Hisashi Hifumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6.0.0.20.2.20060620153929.040f0750@172.19.0.2 \
    --to=hifumi.hisashi@oss.ntt.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=reiser@namesys.com \
    --cc=reiserfs-dev@namesys.com \
    --cc=reiserfs-list@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).