From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from synology.com ([59.124.61.242]:34205 "EHLO synology.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbeHXExB (ORCPT ); Fri, 24 Aug 2018 00:53:01 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 24 Aug 2018 09:20:43 +0800 From: tchou To: =?UTF-8?Q?Ernesto_A=2E_Fern=C3=A1ndez?= Cc: slava@dubeyko.com, linux-fsdevel@vger.kernel.org, htl10@users.sourceforge.net, linux-fsdevel-owner@vger.kernel.org Subject: Re: [PATCH] hfsplus: fix decomposition of Hangul characters In-Reply-To: <20180823182916.ajyci6expu535dcf@eaf> References: <1510906805-2142-1-git-send-email-tchou@synology.com> <20171119005704.GA3495@debian.home> <080024a85dc413b72c181c6e75bdc736@synology.com> <20171123113230.GA5581@debian.home> <1028889c01cdd513c2cf8cabf6c1762e@synology.com> <20171124114525.GA3265@debian.home> <510d6873cbcd4d93f0902c62e3a2c22d@synology.com> <20171127193652.GA3690@debian.home> <20180823182916.ajyci6expu535dcf@eaf> Message-ID: <606d90c202e7c555291c7dde9bf45297@synology.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, Ernesto A. Fernández 於 2018-08-24 02:29 寫到: > Hi again: > > On Mon, Nov 27, 2017 at 04:36:54PM -0300, Ernesto A. Fernández wrote: >> It would be good to have some feedback on the use of code under the >> Unicode License, I don't know if that can be a problem. >> >> To Ting-Chang Hou: This patch is slightly different from the one you >> tested with your mac. You are still tagged as Tested-by, but you may >> want to check again that I have not broken anything. >> >> Thanks, >> Ernest >> >> -- >8 -- >> Subject: [PATCH] hfsplus: fix decomposition of Hangul characters >> >> Files created under macOS become essentially unusable under linux if >> their names contain any Hangul, and vice versa. >> >> This happens because the normalization of Hangul characters is a >> special >> case: it can be done algorithmically, without need of a table. The >> hfsplus module deals with Hangul correctly when composing, but >> completely forgets about it when performing a decomposition. >> >> Solve this by using the Hangul decomposition function provided in the >> Unicode Standard. It's under the Unicode License, compatible with the >> GPL. >> >> This patch will cause trouble for Hangul filenames already created by >> the module in the past. This shouldn't be a special concern because >> the >> main purpose of the module was always sharing with macOS. If a user >> actually needs to access such a file the nodecompose mount option >> should >> be enough. >> >> Reported-by: Ting-Chang Hou >> Tested-by: Ting-Chang Hou >> Signed-off-by: Ernesto A. Fernández >> > > It took a while but this patch has been merged now. Thanks again for > your > report. And thanks for your patch, too. > > Ernest