From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yura Pakhuchiy Subject: Re: XFS corruption on move from xscale to i686 Date: Thu, 14 Jul 2005 17:45:15 +0300 Message-ID: <60868aed050714074550e0adcf@mail.gmail.com> References: <1120756552.5298.10.camel@pc299.sam-solutions.net> <20050708042146.GA1679@frodo> <60868aed0507130822c2e9e97@mail.gmail.com> <20050714012048.GB937@frodo> <60868aed050714065047e3aaec@mail.gmail.com> <20050714143830.GA17842@infradead.org> Reply-To: Yura Pakhuchiy Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: Nathan Scott , linux-xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tibor@altlinux.ru Return-path: Received: from wproxy.gmail.com ([64.233.184.194]:999 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S261430AbVGNOqH convert rfc822-to-8bit (ORCPT ); Thu, 14 Jul 2005 10:46:07 -0400 Received: by wproxy.gmail.com with SMTP id i34so434165wra for ; Thu, 14 Jul 2005 07:46:04 -0700 (PDT) To: Christoph Hellwig In-Reply-To: <20050714143830.GA17842@infradead.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org 2005/7/14, Christoph Hellwig : > On Thu, Jul 14, 2005 at 04:50:01PM +0300, Yura Pakhuchiy wrote: > > 2005/7/14, Nathan Scott : > > > On Wed, Jul 13, 2005 at 06:22:28PM +0300, Yura Pakhuchiy wrote: > > > > I found patch by Greg Ungreger to fix this problem, but why it's still > > > > not in mainline? Or it's a gcc problem and should be fixed by gcc folks? > > > > > > Yes, IIRC the patch was incorrect for other platforms, and it sure > > > looked like an arm-specific gcc problem (this was ages back, so > > > perhaps its fixed by now). > > > > AFAIR gcc-3.4.3 was released after this conversation take place at linux-xfs, > > maybe add something like this: > > > > #ifdef XSCALE > > /* We need this because some gcc versions for xscale are broken. */ > > [patched version here] > > #else > > [original version here] > > #endif > > no, just fix your compiler or let the gcc folks do it. Did anyone of > the arm folks ever open a PR at the gcc bugzilla with a reproduced > testcase? You're never get your compiler fixed with that attitude. Yes, but a lof of people use older versions of compilers and suffer from this bug. I personally was very unhappy when lost my data. Best regards, Yura