linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Finn Thain <fthain@linux-m68k.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Jeff Layton <jlayton@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Dmitry Vyukov <dvyukov@google.com>,
	Viacheslav Dubeyko <slava@dubeyko.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	syzbot <syzbot+7bb7cd3595533513a9e7@syzkaller.appspotmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	christian.brauner@ubuntu.com,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	syzkaller-bugs@googlegroups.com,
	ZhangPeng <zhangpeng362@huawei.com>,
	linux-m68k@lists.linux-m68k.org,
	debian-ports <debian-ports@lists.debian.org>
Subject: Re: [syzbot] [hfs?] WARNING in hfs_write_inode
Date: Fri, 21 Jul 2023 11:03:28 +1000 (AEST)	[thread overview]
Message-ID: <60b57ae9-ff49-de1d-d40d-172c9e6d43d5@linux-m68k.org> (raw)
In-Reply-To: <ZLmzSEV6Wk+oRVoL@dread.disaster.area>

On Fri, 21 Jul 2023, Dave Chinner wrote:

> > I suspect that this is one of those catch-22 situations: distros are 
> > going to enable every feature under the sun. That doesn't mean that 
> > anyone is actually _using_ them these days.

I think the value of filesystem code is not just a question of how often 
it gets executed -- it's also about retaining access to the data collected 
in archives, museums, galleries etc. that is inevitably held in old 
formats.

> 
> We need to much more proactive about dropping support for unmaintained 
> filesystems that nobody is ever fixing despite the constant stream of 
> corruption- and deadlock- related bugs reported against them.
> 

IMO, a stream of bug reports is not a reason to remove code (it's a reason 
to revert some commits).

Anyway, that stream of bugs presumably flows from the unstable kernel API, 
which is inherently high-maintenance. It seems that a stable API could be 
more appropriate for any filesystem for which the on-disk format is fixed 
(by old media, by unmaintained FLOSS implementations or abandoned 
proprietary implementations).

Being in userspace, I suppose FUSE could be a stable API though I imagine 
it's not ideal in the sense that migrating kernel code there would be 
difficult. Maybe userspace NFS 4 would be a better fit? (I've no idea, I'm 
out of my depth in /fs...)

Ideally, kernel-to-userspace code migration would be done with automatic 
program transformation -- otherwise it would become another stream of 
bugs.

  reply	other threads:[~2023-07-21  1:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 14:24 [syzbot] [hfs?] WARNING in hfs_write_inode syzbot
2023-01-04 14:43 ` Arnd Bergmann
2023-01-04 19:06   ` Linus Torvalds
2023-01-04 22:33     ` Arnd Bergmann
2023-01-04 22:42       ` John Paul Adrian Glaubitz
2023-01-05  0:36       ` Viacheslav Dubeyko
2023-01-05  4:37         ` Viacheslav Dubeyko
2023-01-05 15:46           ` Matthew Wilcox
2023-01-05 16:45             ` Viacheslav Dubeyko
2023-07-20 15:27               ` Dmitry Vyukov
2023-07-20 17:30                 ` Matthew Wilcox
2023-07-20 17:50                   ` John Paul Adrian Glaubitz
2023-07-20 17:59                     ` Matthew Wilcox
2023-07-20 18:27                       ` Jeff Layton
2023-07-20 22:20                         ` Dave Chinner
2023-07-21  1:03                           ` Finn Thain [this message]
2023-07-21  1:11                             ` Matthew Wilcox
2023-07-21  1:25                               ` Michael Schmitz
2023-07-21  1:45                               ` Finn Thain
2023-07-21  6:42                               ` Kirsten Bromilow
2023-07-21  8:14                               ` Finn Thain
2023-07-21 13:10                                 ` Theodore Ts'o
2023-07-20 21:38                       ` Jeffrey Walton
2023-07-20 22:37                         ` Matthew Wilcox
2023-07-20 22:53                           ` Linus Torvalds
2023-07-21  1:28                             ` Mike Hosken
2023-07-20 17:56                   ` John Paul Adrian Glaubitz
2023-07-20 19:05                     ` Michael Schmitz
2023-07-21  5:07                       ` John Paul Adrian Glaubitz
2023-07-21  5:40                 ` Eric W. Biederman
2023-01-05 21:34       ` Michael Schmitz
2023-01-05 21:53         ` Linus Torvalds
2023-01-05 23:46           ` Michael Schmitz
2023-01-06  7:09             ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60b57ae9-ff49-de1d-d40d-172c9e6d43d5@linux-m68k.org \
    --to=fthain@linux-m68k.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=christian.brauner@ubuntu.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=david@fromorbit.com \
    --cc=debian-ports@lists.debian.org \
    --cc=dvyukov@google.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=slava@dubeyko.com \
    --cc=syzbot+7bb7cd3595533513a9e7@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    --cc=zhangpeng362@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).