* [PATCH] Unlock vfsmount_lock in do_mount
@ 2011-02-23 7:59 J. R. Okajima
2011-02-24 1:10 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: J. R. Okajima @ 2011-02-23 7:59 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-fsdevel, J. R. Okajima, Nick Piggin
By the commit
b3e19d9 2011-01-07 fs: scale mntget/mntput
vfsmount_lock was introduced around testing mnt_count.
Fix the mis-typed 'unlock'
Signed-off-by: J. R. Okajima <hooanon05@yahoo.co.jp>
---
fs/namespace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index 7b0b953..d1edf26 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1244,7 +1244,7 @@ static int do_umount(struct vfsmount *mnt, int flags)
*/
br_write_lock(vfsmount_lock);
if (mnt_get_count(mnt) != 2) {
- br_write_lock(vfsmount_lock);
+ br_write_unlock(vfsmount_lock);
return -EBUSY;
}
br_write_unlock(vfsmount_lock);
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Unlock vfsmount_lock in do_mount
2011-02-23 7:59 [PATCH] Unlock vfsmount_lock in do_mount J. R. Okajima
@ 2011-02-24 1:10 ` Al Viro
2011-02-24 4:11 ` J. R. Okajima
0 siblings, 1 reply; 3+ messages in thread
From: Al Viro @ 2011-02-24 1:10 UTC (permalink / raw)
To: J. R. Okajima; +Cc: linux-kernel, linux-fsdevel, Nick Piggin
On Wed, Feb 23, 2011 at 04:59:49PM +0900, J. R. Okajima wrote:
> By the commit
> b3e19d9 2011-01-07 fs: scale mntget/mntput
> vfsmount_lock was introduced around testing mnt_count.
> Fix the mis-typed 'unlock'
Gyah... Nice catch. Applied, will push tonight.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Unlock vfsmount_lock in do_mount
2011-02-24 1:10 ` Al Viro
@ 2011-02-24 4:11 ` J. R. Okajima
0 siblings, 0 replies; 3+ messages in thread
From: J. R. Okajima @ 2011-02-24 4:11 UTC (permalink / raw)
To: Al Viro; +Cc: linux-kernel, linux-fsdevel, Nick Piggin
Al Viro:
> On Wed, Feb 23, 2011 at 04:59:49PM +0900, J. R. Okajima wrote:
> > By the commit
> > b3e19d9 2011-01-07 fs: scale mntget/mntput
> > vfsmount_lock was introduced around testing mnt_count.
> > Fix the mis-typed 'unlock'
>
> Gyah... Nice catch. Applied, will push tonight.
Thanks.
But I made a mistake in the subject.
It should be "do_umount" instead of "do_mount". Please fix it when you
push. Otherwise I will post the fixed one.
J. R. Okajima
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-24 4:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-23 7:59 [PATCH] Unlock vfsmount_lock in do_mount J. R. Okajima
2011-02-24 1:10 ` Al Viro
2011-02-24 4:11 ` J. R. Okajima
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).