From: Martin Wilck <mwilck@suse.com>
To: David Disseldorp <ddiss@suse.de>, linux-fsdevel@vger.kernel.org
Cc: viro@zeniv.linux.org.uk, willy@infradead.org
Subject: Re: [PATCH v6 4/6] gen_init_cpio: fix short read file handling
Date: Wed, 12 Jan 2022 16:38:35 +0100 [thread overview]
Message-ID: <6181df9237e121affdb432c86c7408b50ad08afe.camel@suse.com> (raw)
In-Reply-To: <20220107133814.32655-5-ddiss@suse.de>
On Fri, 2022-01-07 at 14:38 +0100, David Disseldorp wrote:
> When processing a "file" entry, gen_init_cpio attempts to allocate a
> buffer large enough to stage the entire contents of the source file.
> It then attempts to fill the buffer via a single read() call and
> subsequently writes out the entire buffer length, without checking
> that
> read() returned the full length, potentially writing uninitialized
> buffer memory.
>
> Fix this by breaking up file I/O into 64k chunks and only writing the
> length returned by the prior read() call.
>
> Signed-off-by: David Disseldorp <ddiss@suse.de>
Looks ok to me.
Reviewed-by: Martin Wilck <mwilck@suse.com>
next prev parent reply other threads:[~2022-01-12 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 13:38 [PATCH v6 0/6] initramfs: "crc" cpio format and INITRAMFS_PRESERVE_MTIME David Disseldorp
2022-01-07 13:38 ` [PATCH v6 1/6] initramfs: refactor do_header() cpio magic checks David Disseldorp
2022-01-07 13:52 ` Christian Brauner
2022-01-07 13:38 ` [PATCH v6 2/6] initramfs: make dir_entry.name a flexible array member David Disseldorp
2022-01-07 13:46 ` Christian Brauner
2022-01-07 13:38 ` [PATCH v6 3/6] initramfs: add INITRAMFS_PRESERVE_MTIME Kconfig option David Disseldorp
2022-03-08 13:09 ` David Disseldorp
2022-03-10 3:41 ` Andrew Morton
2022-01-07 13:38 ` [PATCH v6 4/6] gen_init_cpio: fix short read file handling David Disseldorp
2022-01-12 15:38 ` Martin Wilck [this message]
2022-01-07 13:38 ` [PATCH v6 5/6] gen_init_cpio: support file checksum archiving David Disseldorp
2022-01-07 13:38 ` [PATCH v6 6/6] initramfs: support cpio extraction with file checksums David Disseldorp
2022-01-18 17:25 ` [PATCH v6 0/6] initramfs: "crc" cpio format and INITRAMFS_PRESERVE_MTIME David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6181df9237e121affdb432c86c7408b50ad08afe.camel@suse.com \
--to=mwilck@suse.com \
--cc=ddiss@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).