From mboxrd@z Thu Jan 1 00:00:00 1970 From: hooanon05@yahoo.co.jp Subject: Re: [RFC Aufs2 #3 2/2] split 'xino' entry under sysfs Date: Fri, 20 Mar 2009 14:15:49 +0900 Message-ID: <6218.1237526149@jrobl> References: <1237439565-25039-1-git-send-email-hooanon05@yahoo.co.jp> <1237439565-25039-3-git-send-email-hooanon05@yahoo.co.jp> <20090320004539.GF18781@kroah.com> <3934.1237515949@jrobl> <20090320024249.GA19989@kroah.com> <4443.1237517709@jrobl> <20090320030608.GA2638@kroah.com> <5142.1237521581@jrobl> <20090320041811.GA3352@kroah.com> Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Greg KH Return-path: In-Reply-To: <20090320041811.GA3352@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Greg KH: > Looks like a good start, if you are _sure_ you need sysfs files :) I believe those paths are important to users. When CONFIG_SYSFS is disabled, they are printed in /proc/mounts (and has severer limit). Addition to set limit, there is one more reason to adopt seq_file. Because the printed string is a path, it may contain unprintable characters. seq_file has a good interface seq_path() which supports escaping such characters. J. R. Okajima