From: Dan Williams <dan.j.williams@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>
Cc: Brian Foster <bfoster@redhat.com>, Linux-MM <linux-mm@kvack.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: writeback completion soft lockup BUG in folio_wake_bit()
Date: Wed, 19 Oct 2022 18:35:44 -0700 [thread overview]
Message-ID: <6350a5f07bae2_6be12944c@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <CAHk-=wh6V6TZjjnqBvktbaho_wqfjZYQ9zcKJTV8EP2Kygn0uQ@mail.gmail.com>
Linus Torvalds wrote:
> On Fri, Mar 18, 2022 at 7:45 AM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > Excellent! I'm going to propose these two patches for -rc1 (I don't
> > think we want to be playing with this after -rc8)
>
> Ack. I think your commit message may be a bit too optimistic (who
> knows if other loads can trigger the over-long page locking wait-queue
> latencies), but since I don't see any other ways to really check this
> than just trying it, let's do it.
>
> Linus
A report from a tester with this call trace:
watchdog: BUG: soft lockup - CPU#127 stuck for 134s! [ksoftirqd/127:782]
RIP: 0010:_raw_spin_unlock_irqrestore+0x19/0x40
[..]
Call Trace:
<TASK>
folio_wake_bit+0x8a/0x110
folio_end_writeback+0x37/0x80
ext4_finish_bio+0x19a/0x270
ext4_end_bio+0x47/0x140
blk_update_request+0x112/0x410
...lead me to this thread. This was after I had them force all softirqs
to run in ksoftirqd context, and run with rq_affinity == 2 to force
I/O completion work to throttle new submissions.
Willy, are these headed upstream:
https://lore.kernel.org/all/YjSbHp6B9a1G3tuQ@casper.infradead.org
...or I am missing an alternate solution posted elsewhere?
next prev parent reply other threads:[~2022-10-20 1:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 19:07 writeback completion soft lockup BUG in folio_wake_bit() Brian Foster
2022-03-16 20:59 ` Matthew Wilcox
2022-03-16 23:35 ` Linus Torvalds
2022-03-17 15:04 ` Matthew Wilcox
2022-03-17 19:26 ` Linus Torvalds
2022-03-17 21:16 ` Matthew Wilcox
2022-03-17 22:52 ` Dave Chinner
2022-03-18 13:16 ` Jan Kara
2022-03-18 18:56 ` Linus Torvalds
2022-03-19 16:23 ` Theodore Ts'o
2022-03-30 15:55 ` Christoph Hellwig
2022-03-17 15:31 ` Brian Foster
2022-03-17 13:51 ` Brian Foster
2022-03-18 14:14 ` Brian Foster
2022-03-18 14:45 ` Matthew Wilcox
2022-03-18 18:58 ` Linus Torvalds
2022-10-20 1:35 ` Dan Williams [this message]
2022-10-23 22:38 ` Linus Torvalds
2022-10-24 19:39 ` Tim Chen
2022-10-24 19:43 ` Linus Torvalds
2022-10-24 20:14 ` Dan Williams
2022-10-24 20:13 ` Dan Williams
2022-10-24 20:28 ` Linus Torvalds
2022-10-24 20:35 ` Dan Williams
2022-10-25 15:58 ` Arechiga Lopez, Jesus A
2022-10-25 19:19 ` Matthew Wilcox
2022-10-25 19:20 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6350a5f07bae2_6be12944c@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=bfoster@redhat.com \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).