From: Bob Peterson <rpeterso@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Steven Whitehouse <swhiteho@redhat.com>,
cluster-devel@redhat.com
Subject: Re: [PATCH 4/7] gfs2: Make flush bios explicitely sync
Date: Tue, 2 May 2017 11:44:48 -0400 (EDT) [thread overview]
Message-ID: <641052594.3250061.1493739888083.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170502150351.29452-5-jack@suse.cz>
----- Original Message -----
| Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as
| synchronous" removed REQ_SYNC flag from WRITE_{FUA|PREFLUSH|...}
| definitions. generic_make_request_checks() however strips REQ_FUA and
| REQ_PREFLUSH flags from a bio when the storage doesn't report volatile
| write cache and thus write effectively becomes asynchronous which can
| lead to performance regressions
|
| Fix the problem by making sure all bios which are synchronous are
| properly marked with REQ_SYNC.
Hi,
Looks good.
Acked-by: Bob Peterson <rpeterso@redhat.com>
Regards,
Bob Peterson
Red Hat File Systems
next prev parent reply other threads:[~2017-05-02 15:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 15:03 [PATCH 0/7] Fix fallout from changes to FUA and PREFLUSH definitions Jan Kara
2017-05-02 15:03 ` [PATCH 1/7] ext4: Mark superblock writes synchronous for nobarrier mounts Jan Kara
2017-05-04 15:00 ` Theodore Ts'o
2017-05-02 15:03 ` [PATCH 2/7] jbd2: Cleanup write flags handling from jbd2_write_superblock() Jan Kara
2017-05-04 15:00 ` Theodore Ts'o
2017-05-02 15:03 ` [PATCH 3/7] f2fs: Make flush bios explicitely sync Jan Kara
2017-05-03 16:20 ` [f2fs-dev] " Chao Yu
2017-05-03 21:22 ` Jaegeuk Kim
2017-05-04 7:32 ` Jan Kara
2017-05-04 7:34 ` Jan Kara
2017-05-04 7:36 ` Jaegeuk Kim
2017-05-02 15:03 ` [PATCH 4/7] gfs2: " Jan Kara
2017-05-02 15:44 ` Bob Peterson [this message]
2017-05-02 15:03 ` [PATCH 5/7] reiserfs: " Jan Kara
2017-05-02 15:03 ` [PATCH 6/7] btrfs: " Jan Kara
2017-05-02 15:38 ` David Sterba
2017-05-09 19:09 ` Liu Bo
2017-05-02 15:03 ` [PATCH 7/7] md: " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641052594.3250061.1493739888083.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).