From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:34538 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbdEBPov (ORCPT ); Tue, 2 May 2017 11:44:51 -0400 Date: Tue, 2 May 2017 11:44:48 -0400 (EDT) From: Bob Peterson To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Steven Whitehouse , cluster-devel@redhat.com Message-ID: <641052594.3250061.1493739888083.JavaMail.zimbra@redhat.com> In-Reply-To: <20170502150351.29452-5-jack@suse.cz> References: <20170502150351.29452-1-jack@suse.cz> <20170502150351.29452-5-jack@suse.cz> Subject: Re: [PATCH 4/7] gfs2: Make flush bios explicitely sync MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: ----- Original Message ----- | Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as | synchronous" removed REQ_SYNC flag from WRITE_{FUA|PREFLUSH|...} | definitions. generic_make_request_checks() however strips REQ_FUA and | REQ_PREFLUSH flags from a bio when the storage doesn't report volatile | write cache and thus write effectively becomes asynchronous which can | lead to performance regressions | | Fix the problem by making sure all bios which are synchronous are | properly marked with REQ_SYNC. Hi, Looks good. Acked-by: Bob Peterson Regards, Bob Peterson Red Hat File Systems