From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21ADCC77B78 for ; Fri, 21 Apr 2023 19:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233501AbjDUTVS (ORCPT ); Fri, 21 Apr 2023 15:21:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233327AbjDUTVQ (ORCPT ); Fri, 21 Apr 2023 15:21:16 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F08381BFC for ; Fri, 21 Apr 2023 12:21:14 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-63b733fd00bso2193557b3a.0 for ; Fri, 21 Apr 2023 12:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682104874; x=1684696874; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=y34/3wROOwbQpwlKmyW2uqmf6l0AVBxPz5WfhNq4KHg=; b=kz2QyMieRrGA6qQv9ZTsMc6xckfIEZTcWfHc45KYmNBORLu99xvjM5iBQ/h6XsGjEF p98D6Dfv6FuoDyOTjwmXLoz2bA6HsiT1lzXl2fxmbsk99TnqhObjBpL+ZFGzyLYxaeXz iUF7WnzoPCom6vc//CAfNexxHcPcbC3jYjBEw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682104874; x=1684696874; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y34/3wROOwbQpwlKmyW2uqmf6l0AVBxPz5WfhNq4KHg=; b=kajzOZ2TlhAPtcCmb2XMQkIfSaaniZk01xwicpMSVU+O/zJS0Y5I1PYxU4JV0+egNU 63LBRHW5vAtJEG/lptcJkB0wwdbrt4OtnfzFOtNsxmTb8B2CnpzsWhXFKysYsxseyhSE I+OubutWFMnNiYZHF8vnYuxpK3Kms0ExBwxN+C4KmdqRKs456YW721Z1mCDM32hSKDHt o1CgH7efewQbPEBUEi0ruotYdn7Td43YwooiT3lUMkOOLNCzfqhwx5tdbBWT+H9hxN2N am7et5me03Gfl6VPiY1HxQx5JxQM3tNGvxQ88jAOALuUtYagqwMRwC9pd9OK8L4cRS0k sUbA== X-Gm-Message-State: AAQBX9eurJ9Od7p41Ub0p4+Bfghvedr+ExHbrZayot79XI0cA+lh2R/Y 2yvR1aXOHyMl2qkICp7+TgXAOA== X-Google-Smtp-Source: AKy350b5R7II59/hpeG8VozLIQvSTXVuykBo4PjPNx9fSIfN81f/BKJs12kaFvJI4ZVdawZu/9JU3g== X-Received: by 2002:a05:6a00:2291:b0:63d:4752:4dad with SMTP id f17-20020a056a00229100b0063d47524dadmr8001311pfe.31.1682104874448; Fri, 21 Apr 2023 12:21:14 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id q25-20020a62e119000000b005941ff79428sm3428774pfh.90.2023.04.21.12.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 12:21:14 -0700 (PDT) Message-ID: <6442e22a.620a0220.c118a.7436@mx.google.com> X-Google-Original-Message-ID: <202304211221.@keescook> Date: Fri, 21 Apr 2023 12:21:13 -0700 From: Kees Cook To: Casey Schaufler Cc: paul@paul-moore.com, linux-security-module@vger.kernel.org, jmorris@namei.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, mic@digikod.net, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v9 03/11] proc: Use lsmids instead of lsm names for attrs References: <20230421174259.2458-1-casey@schaufler-ca.com> <20230421174259.2458-4-casey@schaufler-ca.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421174259.2458-4-casey@schaufler-ca.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Apr 21, 2023 at 10:42:51AM -0700, Casey Schaufler wrote: > Use the LSM ID number instead of the LSM name to identify which > security module's attibute data should be shown in /proc/self/attr. > The security_[gs]etprocattr() functions have been changed to expect > the LSM ID. The change from a string comparison to an integer comparison > in these functions will provide a minor performance improvement. > > Signed-off-by: Casey Schaufler Reviewed-by: Kees Cook -- Kees Cook