From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75030C433F5 for ; Sat, 18 Sep 2021 07:08:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C36460F93 for ; Sat, 18 Sep 2021 07:08:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242349AbhIRHJk (ORCPT ); Sat, 18 Sep 2021 03:09:40 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9748 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242292AbhIRHJj (ORCPT ); Sat, 18 Sep 2021 03:09:39 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HBMML258XzWM09; Sat, 18 Sep 2021 15:07:10 +0800 (CST) Received: from dggema766-chm.china.huawei.com (10.1.198.208) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.8; Sat, 18 Sep 2021 15:08:14 +0800 Received: from [10.174.177.210] (10.174.177.210) by dggema766-chm.china.huawei.com (10.1.198.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Sat, 18 Sep 2021 15:08:13 +0800 Message-ID: <64893b00-d606-8ea9-0fd7-c6c819e5d387@huawei.com> Date: Sat, 18 Sep 2021 15:08:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] ramfs: fix mount source show for ramfs From: yangerkun To: Andrew Morton , Al Viro CC: , , , , , References: <20210811122811.2288041-1-yangerkun@huawei.com> <720f6c7a-6745-98ad-5c71-7747857a7f01@huawei.com> <20210908153958.19054d439ae59ee3a7e41519@linux-foundation.org> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.210] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggema766-chm.china.huawei.com (10.1.198.208) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Ping... 在 2021/9/13 9:10, yangerkun 写道: > > > 在 2021/9/9 16:37, yangerkun 写道: >> >> >> 在 2021/9/9 6:39, Andrew Morton 写道: >>> On Wed, 8 Sep 2021 16:56:25 +0800 yangerkun >>> wrote: >>> >>>> 在 2021/8/11 20:28, yangerkun 写道: >>>>> ramfs_parse_param does not parse key "source", and will convert >>>>> -ENOPARAM to 0. This will skip vfs_parse_fs_param_source in >>>>> vfs_parse_fs_param, which lead always "none" mount source for >>>>> ramfs. Fix >>>>> it by parse "source" in ramfs_parse_param. >>>>> >>>>> Signed-off-by: yangerkun >>>>> --- >>>>>    fs/ramfs/inode.c | 4 ++++ >>>>>    1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c >>>>> index 65e7e56005b8..0d7f5f655fd8 100644 >>>>> --- a/fs/ramfs/inode.c >>>>> +++ b/fs/ramfs/inode.c >>>>> @@ -202,6 +202,10 @@ static int ramfs_parse_param(struct fs_context >>>>> *fc, struct fs_parameter *param) >>>>>        struct ramfs_fs_info *fsi = fc->s_fs_info; >>>>>        int opt; >>>>> +    opt = vfs_parse_fs_param_source(fc, param); >>>>> +    if (opt != -ENOPARAM) >>>>> +        return opt; >>>>> + >>>>>        opt = fs_parse(fc, ramfs_fs_parameters, param, &result); >>>>>        if (opt < 0) { >>>>>            /* >>>>> >>> >>> (top-posting repaired) >>> >>>> Hi, this patch seems still leave in linux-next, should we pull it to >>>> mainline? >>> >>> I was hoping for a comment from Al? >> >> Hi, Al, >> >> Can you help to review this patch... > > Hi, Al, > > Sorry for the noise again, can you help to give some comments for this > patch. > >> >> Thanks, >> Kun. >> >>> . >>> >> . > .