From: Ira Weiny <ira.weiny@intel.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Matthew Wilcox <willy@infradead.org>
Cc: Sumitra Sharma <sumitraartsy@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Ira Weiny <ira.weiny@intel.com>, "Deepak R Varma" <drv@mailo.com>
Subject: Re: [PATCH] fs/vboxsf: Replace kmap() with kmap_local_{page, folio}()
Date: Wed, 28 Jun 2023 19:13:32 -0700 [thread overview]
Message-ID: <649ce8cc8375e_92a162947@iweiny-mobl.notmuch> (raw)
In-Reply-To: <2882298.SvYEEZNnvj@suse>
Fabio M. De Francesco wrote:
> On giovedì 29 giugno 2023 00:23:54 CEST Fabio M. De Francesco wrote:
>
> [...]
>
> >
> > Shouldn't we call folio_lock() to lock the folio to be able to unlock with
> > folio_unlock()?
>
> Sorry, I wanted to write "If so, I can't find either a folio_lock() or a
> page_lock() in this filesystem.".
Check the documentation for read_folio:
... "The filesystem should unlock the folio once the read has
completed, whether it was successful or not." ...
Ira
next prev parent reply other threads:[~2023-06-29 2:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 13:51 [PATCH] fs/vboxsf: Replace kmap() with kmap_local_{page, folio}() Sumitra Sharma
2023-06-27 14:34 ` Hans de Goede
2023-06-27 17:46 ` Matthew Wilcox
2023-06-27 18:10 ` Hans de Goede
2023-06-27 18:19 ` Hans de Goede
2023-06-27 17:48 ` Matthew Wilcox
2023-06-27 18:04 ` Hans de Goede
2023-06-29 4:30 ` Sumitra Sharma
2023-06-29 5:35 ` Hans de Goede
2023-06-28 17:15 ` Matthew Wilcox
2023-06-28 22:23 ` Fabio M. De Francesco
2023-06-28 22:40 ` Fabio M. De Francesco
2023-06-29 2:13 ` Ira Weiny [this message]
2023-06-29 3:16 ` Matthew Wilcox
2023-06-29 15:04 ` Fabio M. De Francesco
2023-06-29 2:23 ` Ira Weiny
2023-06-29 3:08 ` Matthew Wilcox
2023-06-29 9:28 ` Sumitra Sharma
2023-06-29 10:01 ` Hans de Goede
2023-06-29 14:42 ` Matthew Wilcox
2023-06-29 15:01 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=649ce8cc8375e_92a162947@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=drv@mailo.com \
--cc=fmdefrancesco@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumitraartsy@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox