linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Kaiser" <just.for.lkml@googlemail.com>
To: "Peter Zijlstra" <peterz@infradead.org>
Cc: "David Chinner" <dgc@sgi.com>,
	"Fengguang Wu" <wfg@mail.ustc.edu.cn>,
	"Maxim Levitsky" <maximlevitsky@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: writeout stalls in current -git
Date: Tue, 6 Nov 2007 21:26:05 +0100	[thread overview]
Message-ID: <64bb37e0711061226l48dce395ub2f9539efc66ecc0@mail.gmail.com> (raw)
In-Reply-To: <1194375682.6289.88.camel@twins>

On 11/6/07, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, 2007-11-06 at 15:25 +1100, David Chinner wrote:
>
> > I'm struggling to understand what possible changed in XFS or writeback that
> > would lead to stalls like this, esp. as you appear to be removing files when
> > the stalls occur.
>
> Just a crazy idea,..
>
> Could there be a set_page_dirty() that doesn't have
> balance_dirty_pages() call near? For example modifying meta data in
> unlink?
>
> Such a situation could lead to an excess of dirty pages and the next
> call to balance_dirty_pages() would appear to stall, as it would
> desperately try to get below the limit again.

Only if accounting of the dirty pages is also broken.
In the unmerge testcase I see most of the time only <200kb of dirty
data in /proc/meminfo.

The system has 4Gb of RAM so I'm not sure if it should ever be valid
to stall even the emerge/install testcase.

Torsten

Now building a kernel with the skipped-pages-accounting-patch reverted...

  reply	other threads:[~2007-11-06 20:26 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200710220822.52370.maximlevitsky@gmail.com>
     [not found] ` <200710221258.11384.maximlevitsky@gmail.com>
     [not found]   ` <393051953.24752@ustc.edu.cn>
     [not found]     ` <200710221421.21439.maximlevitsky@gmail.com>
     [not found]       ` <393126119.26275@ustc.edu.cn>
     [not found]         ` <1193134027.7406.1.camel@twins>
     [not found]           ` <20071023115620.GA5678@mail.ustc.edu.cn>
2007-10-23 11:56             ` [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file Fengguang Wu
2007-10-23 14:10               ` Chris Mason
     [not found]                 ` <20071023144014.GA6174@mail.ustc.edu.cn>
2007-10-23 14:40                   ` Fengguang Wu
2007-10-23 14:40                   ` Fengguang Wu
2007-10-23 11:56             ` Fengguang Wu
     [not found]       ` <393056632.00561@ustc.edu.cn>
     [not found]         ` <200710221505.35397.maximlevitsky@gmail.com>
     [not found]           ` <20071022131045.GA5357@mail.ustc.edu.cn>
     [not found]             ` <393060478.03650@ustc.edu.cn>
     [not found]               ` <64bb37e0710310822r5ca6b793p8fd97db2f72a8655@mail.gmail.com>
     [not found]                 ` <393903856.06449@ustc.edu.cn>
     [not found]                   ` <64bb37e0711011120i63cdfe3ci18995d57b6649a8@mail.gmail.com>
     [not found]                     ` <E1Inljm-0002DW-CL@localhost>
2007-11-02  1:54                       ` writeout stalls in current -git Fengguang Wu
2007-11-02  7:42                         ` Torsten Kaiser
     [not found]                           ` <E1InrKN-0000MK-G5@localhost>
2007-11-02  7:52                             ` Fengguang Wu
2007-11-02  7:52                             ` Fengguang Wu
2007-11-02 17:47                               ` Torsten Kaiser
2007-11-02  1:54                       ` Fengguang Wu
     [not found]                     ` <64bb37e0711011200n228e708eg255640388f83da22@mail.gmail.com>
     [not found]                       ` <E1InmAI-0003ME-2i@localhost>
2007-11-02  2:21                         ` Fengguang Wu
2007-11-02  2:21                         ` Fengguang Wu
2007-11-02  7:50                           ` Torsten Kaiser
2007-11-02 10:15                         ` Peter Zijlstra
     [not found]                           ` <E1IntqD-0001dK-OE@localhost>
2007-11-02 10:33                             ` Fengguang Wu
2007-11-02 10:33                             ` Fengguang Wu
2007-11-05 23:57                               ` Andrew Morton
2007-11-06 10:20                                 ` Peter Zijlstra
2007-11-02 19:22                           ` Torsten Kaiser
2007-11-02 20:43                             ` David Chinner
2007-11-02 21:02                               ` Torsten Kaiser
2007-11-04 11:19                               ` Torsten Kaiser
2007-11-05  1:45                                 ` David Chinner
2007-11-05  7:01                                   ` Torsten Kaiser
2007-11-05 18:27                                   ` Torsten Kaiser
2007-11-06  4:25                                     ` David Chinner
2007-11-06  7:10                                       ` Torsten Kaiser
2007-11-06 19:01                                       ` Peter Zijlstra
2007-11-06 20:26                                         ` Torsten Kaiser [this message]
     [not found]                             ` <E1IpKZ4-0004je-Lb@localhost>
2007-11-06  9:17                               ` Fengguang Wu
2007-11-06 21:53                                 ` Torsten Kaiser
2007-11-06 23:31                                   ` David Chinner
2007-11-07  2:13                                     ` David Chinner
2007-11-07  7:15                                       ` Torsten Kaiser
2007-11-08  0:38                                         ` David Chinner
2007-11-20 13:16                                           ` Damien Wyart
2007-11-20 21:09                                             ` David Chinner
2007-11-06  9:17                               ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64bb37e0711061226l48dce395ub2f9539efc66ecc0@mail.gmail.com \
    --to=just.for.lkml@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dgc@sgi.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=peterz@infradead.org \
    --cc=wfg@mail.ustc.edu.cn \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).