From mboxrd@z Thu Jan  1 00:00:00 1970
From: Torsten Kaiser <just.for.lkml@googlemail.com>
Subject: Re: xfs compat_ioctl?
Date: Tue, 1 Sep 2009 19:00:05 +0200
Message-ID: <64bb37e0909011000l78a0aef0wf4c53252c14af75e@mail.gmail.com>
References: <4A9B759B.7020401@msgid.tls.msk.ru>
	 <20090831123010.GA2368@infradead.org>
	 <64bb37e0908311114t4a3cefc3v8ea5092e1558c578@mail.gmail.com>
	 <20090831182754.GA3620@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Cc: Michael Tokarev <mjt@tls.msk.ru>,
	Linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>, xfs@oss.sgi.com
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-fx0-f217.google.com ([209.85.220.217]:42593 "EHLO
	mail-fx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754772AbZIARAF (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 1 Sep 2009 13:00:05 -0400
In-Reply-To: <20090831182754.GA3620@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Aug 31, 2009 at 8:27 PM, Christoph Hellwig<hch@infradead.org> wrote:
> I think you are right, the constant used is incorrect.  Does the small
> patch below fix it for you?

Yes, after adding this patch, xfs_fsr works.

> Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c       2009-08-31 15:25:06.093044591 -0300
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c    2009-08-31 15:25:10.856544216 -0300
> @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
>        case XFS_IOC_GETVERSION_32:
>                cmd = _NATIVE_IOC(cmd, long);
>                return xfs_file_ioctl(filp, cmd, p);
> -       case XFS_IOC_SWAPEXT: {
> +       case XFS_IOC_SWAPEXT_32: {
>                struct xfs_swapext        sxp;
>                struct compat_xfs_swapext __user *sxu = arg;
>
>