From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 22/43] CacheFiles: Add a hook to write a single page of data to an inode [ver #46] Date: Thu, 02 Apr 2009 17:03:16 +0100 Message-ID: <6509.1238688196@redhat.com> References: <49D4DA7E.7010508@redhat.com> <20090401230321.28177.12010.stgit@warthog.procyon.org.uk> <20090401230515.28177.73948.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, nfsv4@linux-nfs.org, viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org To: Peter Staubach Return-path: In-Reply-To: <49D4DA7E.7010508@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-Id: linux-fsdevel.vger.kernel.org Peter Staubach wrote: > > + .write_one_page = generic_file_buffered_write_one_page, > > + .write_one_page = generic_file_buffered_write_one_page, > > > > You probably only need one of these lines, don't you? Yes: one should be in ext2_aops, thanks. David