From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A54E7EB64DC for ; Fri, 21 Jul 2023 15:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231909AbjGUPOa (ORCPT ); Fri, 21 Jul 2023 11:14:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbjGUPOQ (ORCPT ); Fri, 21 Jul 2023 11:14:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C4C630DD for ; Fri, 21 Jul 2023 08:13:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689952377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KuECWgmrt4c8ZTlDSWFvVOJXkvdaI59iER7noO41RWI=; b=EvkoIsl1Ald/n0VtWGIJbPb/A4z3GOpRj0Fhdz3yIaJA9+IuTR5LFPxCvPVCsM/PPQhaFn qzg5hwNlD9wRgSbxTD2TWcJDQZR8wW/OAEghdUsxebgITTS5FZ+r49v9XHkPvQUSvVRIbm nP7MgLrNUnZr075+tH0CO8K6Rm76QwU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-IIPBRq2jM2iJv0zLLCDtEQ-1; Fri, 21 Jul 2023 11:12:55 -0400 X-MC-Unique: IIPBRq2jM2iJv0zLLCDtEQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4fb87c48aceso2076345e87.3 for ; Fri, 21 Jul 2023 08:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689952374; x=1690557174; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KuECWgmrt4c8ZTlDSWFvVOJXkvdaI59iER7noO41RWI=; b=eg3RZheQVaMlkvs6h1ZjoEV8sazp9bZbP4aeSdcaL8Ru99OnwZmN/LEfXgO1+LDdOU QmLqISoawHhWnL6qDJQVWZ//nBHAwqplcAQ5VvOgtEKW3nmuusgyG3mRxbUKVoelHA5p VlPYHNPTCBts+mG/2oTgFSnJM1c2rN5HqvFRr1QmwT7qq5PGqc8n9LFTUQ88o3YuaSyc dKGmJw2WsYoQGicnCdxXueLRmsw4q0APc7B32Db8/UlyGOZmTtbiillVpxcp/JWqd3bt ZDPYDQMc42j1hZqlIsQuxwO0uoJMqVRQ9aeQH0QnDKeE8dAIOnSEiiudSq8gqIiGXEU4 PxiQ== X-Gm-Message-State: ABy/qLY4ori/62DPqBxkiNnjhtWK+Fsid7m4WAYbYz9u+9sqqZwkkBFc cqvTy7KafuEv4ugzqmHUzaAk0jDl+iUsb30AIAik0Mi3UBAGy/khiBVDu4Fb82b3mdawoGbisr4 g1zQr52zhWBa8ZujSKx2qbuK5dA== X-Received: by 2002:a19:e05b:0:b0:4fb:caed:95c3 with SMTP id g27-20020a19e05b000000b004fbcaed95c3mr1377458lfj.53.1689952374307; Fri, 21 Jul 2023 08:12:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlG7b5XRxViP22WEsYjZVx9eEuQn7vFDvQWd5jPtrRlHnUDSnFTiFx5UF3BQ2XwQWfw7l/MGag== X-Received: by 2002:a19:e05b:0:b0:4fb:caed:95c3 with SMTP id g27-20020a19e05b000000b004fbcaed95c3mr1377407lfj.53.1689952373968; Fri, 21 Jul 2023 08:12:53 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id n1-20020a05640204c100b0051e0f21c43fsm2214094edw.31.2023.07.21.08.12.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 08:12:53 -0700 (PDT) Message-ID: <6519e3f4-7cea-01a6-724e-a0bce10c3c19@redhat.com> Date: Fri, 21 Jul 2023 17:12:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 16/29] KVM: Allow arch code to track number of memslot address spaces per VM Content-Language: en-US To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-17-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20230718234512.1690985-17-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 7/19/23 01:44, Sean Christopherson wrote: > @@ -4725,9 +4725,9 @@ static int kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg) > case KVM_CAP_IRQ_ROUTING: > return KVM_MAX_IRQ_ROUTES; > #endif > -#if KVM_ADDRESS_SPACE_NUM > 1 > +#if KVM_MAX_NR_ADDRESS_SPACES > 1 > case KVM_CAP_MULTI_ADDRESS_SPACE: > - return KVM_ADDRESS_SPACE_NUM; > + return KVM_MAX_NR_ADDRESS_SPACES; > #endif Since this is a VM ioctl, it should return kvm_arch_nr_memslot_as_ids(kvm) if kvm != NULL. Paolo