From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul Menage" Subject: Re: [PATCH] Add MS_BIND_FLAGS mount flag Date: Thu, 14 Feb 2008 10:05:04 -0800 Message-ID: <6599ad830802141005i52236f7ak337ffffb915ea8ce@mail.gmail.com> References: <47B283EB.8070209@google.com> <6599ad830802140719l270d6fdfyd6d17806eda12a8d@mail.gmail.com> <6599ad830802140813n71b56dccud33e19642a0d7647@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: "Miklos Szeredi" Return-path: Received: from smtp-out.google.com ([216.239.33.17]:42993 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753707AbYBNSFN (ORCPT ); Thu, 14 Feb 2008 13:05:13 -0500 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id m1EI582q027652 for ; Thu, 14 Feb 2008 18:05:08 GMT Received: from py-out-1112.google.com (pybu77.prod.google.com [10.34.97.77]) by zps76.corp.google.com with ESMTP id m1EI4lR6006788 for ; Thu, 14 Feb 2008 10:05:05 -0800 Received: by py-out-1112.google.com with SMTP id u77so433005pyb.16 for ; Thu, 14 Feb 2008 10:05:05 -0800 (PST) In-Reply-To: Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Feb 14, 2008 at 9:31 AM, Miklos Szeredi wrote: > > I deliberately not used the MS_* flags, which is currently a messy mix > of things with totally different meanings. > > Does this solve all the issues? We should add a size parameter either in the mount_params or as a final argument, for future extensibility. And we might as well include MNT_READONLY in the API on the assumption that per-mount readonly will be available soon. Paul