From: Dan Williams <dan.j.williams@intel.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
<linux-fsdevel@vger.kernel.org>, <nvdimm@lists.linux.dev>
Cc: <dan.j.williams@intel.com>, <willy@infradead.org>, <jack@suse.cz>
Subject: RE: [PATCH] fsdax: cleanup tracepoints
Date: Thu, 18 Jan 2024 17:59:43 -0800 [thread overview]
Message-ID: <65a9d78fc1ff2_3b8e29413@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20240104104925.3496797-1-ruansy.fnst@fujitsu.com>
Shiyang Ruan wrote:
> Restore the tracepoint that was accidentally deleted before, and rename
> to dax_insert_entry(). Also, since we are using XArray, rename
> 'radix_entry' to 'xa_entry'.
The restore tracepoint patch should be an independent patch.
As for the rename I believe that can potentially break peoples existing
scripts.
So we can try to change it and see if someone screams, but if that needs
to be reverted then having it as a separate patch from the fix makes it
easier to manage.
Effectively, any time you write "Also," in a patch that is usually a
good sign to break up the patch.
prev parent reply other threads:[~2024-01-19 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 10:49 [PATCH] fsdax: cleanup tracepoints Shiyang Ruan
2024-01-04 12:26 ` Jan Kara
2024-01-19 1:52 ` Shiyang Ruan
2024-01-19 1:59 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a9d78fc1ff2_3b8e29413@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox