From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD29C31A9C; Sat, 16 Dec 2023 19:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="s0t50G3l" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=ktnvyamH7pIEdUhebfwu9eUsYoWrjCwsREAxL8GiTW8=; b=s0t50G3lVcBEdsaGSAkuW2sn17 Ql9TV8WbXeJ11fYrIszd76ejd67Jwc6l/qM64/5+AvyshCJNCOakjuzAiew42G55TYh46sh7sQHgk EMzWa3we4SXtR2Jz35Ls1aOBmhmCqMLhaGxhllee/lIEcnFrhTjobnUcbNFIs0XT71H0ogULAUK0z jeG0jv48VNBi0tUFgaWNkmNinfMRpxYMJXMDX4YZUMF0Fb0q6q3oGzIuPvPMMM3Ylp3rGyzjBXxhs 53/nPWmbDIrXx2znJAkv+RkkuNLS3mwQP5vVUkiGcB4VaJrgtpir/kj5N9B6RS/JzDZ0bTNwNFCy3 TprQ7Fyg==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rEa32-006b40-1L; Sat, 16 Dec 2023 19:10:04 +0000 Message-ID: <65c68bf8-c577-4103-ae7e-7871ae276c22@infradead.org> Date: Sat, 16 Dec 2023 11:10:03 -0800 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 26/50] rslib: kill bogus dependency on list.h Content-Language: en-US From: Randy Dunlap To: Kent Overstreet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032957.3553313-1-kent.overstreet@linux.dev> <20231216032957.3553313-5-kent.overstreet@linux.dev> <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org> In-Reply-To: <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/16/23 11:05, Randy Dunlap wrote: > > > On 12/15/23 19:29, Kent Overstreet wrote: >> list_head is defined in types.h, not list.h - this kills a sched.h >> dependency. >> >> Signed-off-by: Kent Overstreet >> --- >> include/linux/rslib.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/linux/rslib.h b/include/linux/rslib.h >> index 238bb85243d3..a04dacbdc8ae 100644 >> --- a/include/linux/rslib.h >> +++ b/include/linux/rslib.h >> @@ -10,7 +10,6 @@ >> #ifndef _RSLIB_H_ >> #define _RSLIB_H_ >> >> -#include >> #include /* for gfp_t */ >> #include /* for GFP_KERNEL */ >> > > What about line 47? > > 47 struct list_head list; > I see. :) it's in types.h, not list.h, as you explained! -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html