From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793958640; b=omXWUNJmD/xHZgX2+jEZavnau6PH5dgKE6dxXq768tjMECAItj1ED+7AskK6L3vX/qSn Q+vaTGpYtF3asTulgovz1ptDxOxlqEiIo7HOQi2c/WFysBeVtRSHyk9lRt1miobjaN1JO +POIa28UfSz/8ROEzT/CjaXxG22BmFIE0QJ9/9PrBvbctJqNrhLqWEgEpDA1FvhzZgth8 HwltiOa3D8LBEq1wwqIvgda54ocSyqqO8bU+9FWpTbmosZ+uW+9azAcsZNJ//ltr1z1Rx uutm8gBCRx0JLHOG3u4kX+rF1NA3zPq7CMAslEmJ638XenB9auhxzWpRUG8SdXNBfQg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793958640; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=RupwrtSRCRknDTCP4U8+mHVorluG3D1aDqrqCuXGL/o=; b=BwX54kQeLv6e6ImU0fbJtH2aFQzfLINd2K6CWKNbpzLVr/JMP7O0GKF1JIdGckNtR1GK 8lJM6MLAzeaLQioad0b+TugjSG2xFJthqOgMyPWZqDqYyZsw3Zi4iOznsQYfMHhPNg7RO 0lJRlhCU4WsxjSXG2V/QcHie7v8/428JpLV2RiLeldU2lbQkgtA8BddMofyUY9af+VYJk qDYSPTMVIr3hvhNZ0qp47A+Tz3FIAi8J78MNlhXvft8+joRS6aqsLYkaos7iBehZu2tjn 5W9daU72z18KceHyLRQRQIzW3k5CfxZHwdQQea33yy5RF2yEKT8KnZo1LFlsIWgve+w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=t1D9H5iu; arc=none smtp.remote-ip=209.85.221.52 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC2C606EEB8 for ; Fri, 6 Nov 2026 09:50:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DEC2C606EEB8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=t1D9H5iu Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-48dfc0421d9so447391f8f.1 for ; Fri, 06 Nov 2026 01:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793958638; x=1794563438; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RupwrtSRCRknDTCP4U8+mHVorluG3D1aDqrqCuXGL/o=; b=t1D9H5iuTUmjdPhOVJmZIub2cA7iiSUr41ZQ3yS+raxwi2K9JW5USUNO1Ej8W7ktyy jDlpr6IYaICDt5N3782Vm+vT8R7N+VD6e282WCZUIr3qHs3ymqVae8nOek4p5Qr6O/oS dqZpOzvc4Swchkzri6wDXvUOBTWJM5lyg5UOT7Y/iAiO/bDMWNay73N2vmeXoqlrNWa3 CWfy2PPZ8DtSbf0uhLB61kRz/tBH8yhEbP0mgAap9N/KETVXb+EF1zhC7HOG5tW8CGpR ZOvm0YUZZDiDTRNjJd5C/6nVAnSAYqMrPeB1m3dSCFZzIl8NAmnARF5bgl9O49QSbyKD /grw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793958638; x=1794563438; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RupwrtSRCRknDTCP4U8+mHVorluG3D1aDqrqCuXGL/o=; b=ccwKy6HTONpdHRbMKlgkPHLr+YovuMDKQg12tUThmzXxvAMafwLQaehzF7t2dT8su7 V5egRBd8nPRCByMcv9XoFlkWoQRKJC9qoQ7klau02G8GPqIG1eovBCd9vbSIeUbCNrdG ucVdOa33ccMvF9w48U1wBuyZr30Mj9t7yy3xht+tLRbNHHoXagNXkDB4//wMiruCOhZR iUvjArgVjAupbBWOO3UjipQTxG5KdCxLhu3Wda8V8WczDCiJtFhYFkkoFzPB80SF9dIf TgLwbgqC8vJM3wVp+7tzZZFJowQ33gNN6oyg0kbWrhs6g1bM45blgaySKQoa9VzwiVrT JbmQ== X-Forwarded-Encrypted: i=1; AL+hErE1/E0H9izSnoThl8fIRGDifhSt/ai4iSBncHMxOSkZhmpP7EgKIb1i2CsSWevaoEfKR7ouAw4XWPLl1ZN9@vger.kernel.org X-Gm-Message-State: APuU4Z8ST9TSteMhibcnIyNqQWOV9XLuxgVXCaOzxDCQXhY9VPPbIKSt 7Pruuzv57ts0tOiBBahRFkMB+KysIg02Kd1acSUVblcCogmfmYnx/Jrj X-Gm-Gg: AYBFou18QikQa/vjkj7lgJ6C7PT42c/aKZGSirF+g2Kkd7DgPLXx4aK6rTDSbrdgwmc tuBjXLBzKj49tFYL1ZiLUdMHp09y6yGeSPd1mDQIbgBa0YpbqqWk8yLnPU2l284naKZEWNmpZOf f9/v6JkbCipZTHu89u1ef1tcQuRqqpzbo66Xnd3nFnuvaraToTOBFOQBbHMf8hoVWvbp4SLuD6Z O2wn9EnIiecFo303fCWWeXVL7m0V/0AyOby4BWH/MAY/OugepXQ4GLzWMkeQID9yn6vK5YpMY0K xxATSdrGx6uh8J30lm+/Ooi5J3f5i+B57Dn29NBOfy2e8Kid0qfYyDisaWmeJ+UCdjDHPlu1wcB tFXuILxqS6mQOJtEwJek1zRXlyUeO8I3oQ6HeMIX1jj0AUanhKZJWdnPMUCEgKyyy6KWIepdimQ Ezi0REbJ1nvNStIJsgId7PiesVflRsl7FlcVzHrU7lL5KCo96Lkd0KQRKPh+pB3uzGFuy6jupJ8 uzxGBWHDN+Demp/wKQLUrqx1HB8I4GYfHNvsJWqxPL/lIcMV8X5lQkSptf0r8NZOzqfKmPVvTWy VzSlwULZDWo+vnpd9sJihR0= X-Received: by 2002:a5d:5d82:0:b0:491:83e7:32bd with SMTP id ffacd0b85a97d-49277f88313mr3982559f8f.50.1793958637679; Fri, 06 Nov 2026 01:50:37 -0800 (PST) Received: from [192.168.1.22] ([83.231.69.9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-492d3d60e78sm2755152f8f.1.2026.11.06.01.50.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Nov 2026 01:50:37 -0800 (PST) Message-ID: <6662ae76-c8dc-4bc5-9730-bf9f537ca9cb@gmail.com> Date: Fri, 6 Nov 2026 10:50:34 +0100 X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] mm: limit pagecache folio refcount when splicing into pipes To: "David Hildenbrand (Arm)" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Jan Kara , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Matthew Brost , Joshua Hahn , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Peter Xu , Johannes Weiner , Song Liu , Rik van Riel , Hugh Dickins , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Jason Gunthorpe , Kevin Tian , "Joerg Roedel (AMD)" , Robin Murphy , Steve Sistare , John Hubbard Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, iommu@lists.linux.dev, stable@vger.kernel.org References: <20261105-refcount_overflow_stable-v1-0-70b9c655da3e@kernel.org> <20261105-refcount_overflow_stable-v1-2-70b9c655da3e@kernel.org> Content-Language: en-US From: "Jose A. Perez de Azpillaga" In-Reply-To: <20261105-refcount_overflow_stable-v1-2-70b9c655da3e@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/5/26 2:10 PM, David Hildenbrand (Arm) wrote: > Similar to mapping pagecache folios into page tables, let's reject splicing > folios into a pipe if the refcount is at it's limit, similar to how we > handle it during GUP. > > This will prevent more cases of possible folio refcount overflows with > large pagecache folios. > > Let's keep it simple and check in the two callers of > splice_folio_into_pipe(). > > Also check in try_get_page() to cover pipe-buffer duplication by tee() > and partial pipe-to-pipe splicing. > > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS") > Fixes: 793917d997df ("mm/readahead: Add large folio readahead") > Cc: stable@vger.kernel.org > Signed-off-by: David Hildenbrand (Arm) LGTM: Reviewed-by: Jose A. Perez de Azpillaga -- cheers, jose a. p-a