linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: xu.xin16@zte.com.cn, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, wang.yaxin@zte.com.cn,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	yang.yang29@zte.com.cn
Subject: Re: [PATCH RESEND 0/6] support ksm_stat showing at cgroup level
Date: Wed, 23 Apr 2025 15:08:20 +0200	[thread overview]
Message-ID: <6663d393-bac8-4bcc-b36b-58b08143d959@redhat.com> (raw)
In-Reply-To: <20250422191407770210-193JBD0Fgeu5zqE2K@zte.com.cn>

On 22.04.25 13:14, xu.xin16@zte.com.cn wrote:
> From: xu xin <xu.xin16@zte.com.cn>
> 
> With the enablement of container-level KSM (e.g., via prctl [1]), there is
> a growing demand for container-level observability of KSM behavior. However,
> current cgroup implementations lack support for exposing KSM-related
> metrics.
> 
> This patch introduces a new interface named ksm_stat
> at the cgroup hierarchy level, enabling users to monitor KSM merging
> statistics specifically for containers where this feature has been
> activated, eliminating the need to manually inspect KSM information for
> each individual process within the cgroup.
> 
> Users can obtain the KSM information of a cgroup just by:
> 
> # cat /sys/fs/cgroup/memory.ksm_stat
> ksm_rmap_items 76800
> ksm_zero_pages 0
> ksm_merging_pages 76800
> ksm_process_profit 309657600
> 
> Current implementation supports cgroup v1 temporarily; cgroup v2
> compatibility is planned for future versions.

As raised by Willy, we focus on v2.

Independent of that, I strongly assume that 
Documentation/admin-guide/cgroup-v1/memory.rst needs care :)

-- 
Cheers,

David / dhildenb


      parent reply	other threads:[~2025-04-23 13:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 11:14 [PATCH RESEND 0/6] support ksm_stat showing at cgroup level xu.xin16
2025-04-22 11:19 ` [PATCH RESEND 1/6] memcontrol: rename mem_cgroup_scan_tasks() xu xin
2025-04-22 23:29   ` Andrew Morton
2025-04-23 12:22     ` Matthew Wilcox
2025-04-25 14:30       ` Michal Hocko
2025-04-22 11:20 ` [PATCH RESEND 2/6] memcontrol: introduce the new mem_cgroup_scan_tasks() xu xin
2025-04-22 11:21 ` [PATCH RESEND 3/6] memcontrol-v1: introduce ksm_stat at cgroup level xu xin
2025-04-22 11:21 ` [PATCH RESEND 4/6] memcontrol-v1: add ksm_zero_pages in cgroup/memory.ksm_stat xu xin
2025-04-22 11:22 ` [PATCH RESEND 5/6] memcontrol-v1: add ksm_merging_pages " xu xin
2025-04-22 11:22 ` [PATCH RESEND 6/6] memcontrol-v1: add ksm_profit " xu xin
2025-04-23  8:21   ` kernel test robot
2025-04-23 13:08 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6663d393-bac8-4bcc-b36b-58b08143d959@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=wang.yaxin@zte.com.cn \
    --cc=xu.xin16@zte.com.cn \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).