From: Randy Dunlap <rdunlap@infradead.org>
To: trix@redhat.com, ebiederm@xmission.com, keescook@chromium.org,
viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] exec: cleanup comments
Date: Fri, 11 Feb 2022 09:12:13 -0800 [thread overview]
Message-ID: <6742c55a-59e5-80db-5490-07cec141f580@infradead.org> (raw)
In-Reply-To: <20220211160940.2516243-1-trix@redhat.com>
On 2/11/22 08:09, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Remove the second 'from'.
> Replace 'backwords' with 'backwards'.
> Replace 'visibile' with 'visible'.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> fs/exec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index 40b1008fb0f7..8256e8bb9ad3 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -118,7 +118,7 @@ bool path_noexec(const struct path *path)
> * Note that a shared library must be both readable and executable due to
> * security reasons.
> *
> - * Also note that we take the address to load from from the file itself.
> + * Also note that we take the address to load from the file itself.
> */
> SYSCALL_DEFINE1(uselib, const char __user *, library)
> {
> @@ -542,7 +542,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
> if (!valid_arg_len(bprm, len))
> goto out;
>
> - /* We're going to work our way backwords. */
> + /* We're going to work our way backwards. */
> pos = bprm->p;
> str += len;
> bprm->p -= len;
> @@ -1275,7 +1275,7 @@ int begin_new_exec(struct linux_binprm * bprm)
>
> /*
> * Must be called _before_ exec_mmap() as bprm->mm is
> - * not visibile until then. This also enables the update
> + * not visible until then. This also enables the update
> * to be lockless.
> */
> retval = set_mm_exe_file(bprm->mm, bprm->file);
--
~Randy
next prev parent reply other threads:[~2022-02-11 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 16:09 [PATCH] exec: cleanup comments trix
2022-02-11 17:12 ` Randy Dunlap [this message]
2022-02-14 19:31 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6742c55a-59e5-80db-5490-07cec141f580@infradead.org \
--to=rdunlap@infradead.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).