From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5E7C6FA86 for ; Tue, 13 Sep 2022 08:40:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbiIMIkG (ORCPT ); Tue, 13 Sep 2022 04:40:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231493AbiIMIjn (ORCPT ); Tue, 13 Sep 2022 04:39:43 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08EE662E9; Tue, 13 Sep 2022 01:39:38 -0700 (PDT) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MRcGY3Gx7zNm7c; Tue, 13 Sep 2022 16:35:01 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 13 Sep 2022 16:39:36 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 13 Sep 2022 16:39:35 +0800 Message-ID: <67867ce9-55f5-e81f-ada9-ea22d31d4f10@huawei.com> Date: Tue, 13 Sep 2022 16:39:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] sched: Move numa_balancing sysctls to its own file Content-Language: en-US To: Luis Chamberlain , Andrew Morton CC: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Kees Cook , Iurii Zaikin , , , Andrew Morton References: <20220908072531.87916-1-wangkefeng.wang@huawei.com> <679d8f0c-f8cc-d43e-5467-c32a78bcb850@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2022/9/10 3:44, Luis Chamberlain wrote: > On Fri, Sep 09, 2022 at 11:37:41AM +0800, Kefeng Wang wrote: >> On 2022/9/9 9:46, Kefeng Wang wrote: >>> On 2022/9/9 8:06, Luis Chamberlain wrote: >>>> On Thu, Sep 08, 2022 at 03:25:31PM +0800, Kefeng Wang wrote: >>>>> The sysctl_numa_balancing_promote_rate_limit and sysctl_numa_balancing >>>>> are part of sched, move them to its own file. >>>>> >>>>> Signed-off-by: Kefeng Wang >>>> There is quite a bit of random cleanup on each kernel release >>>> for sysctls to do things like what you just did. Because of this it >>>> has its >>>> own tree to help avoid conflicts. Can you base your patches on the >>>> sysctl-testing branch here and re-submit: >>> Found this when reading memory tiering code，sure to re-submit based >>> your branch, >>> >>> thanks. >>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-testing >>>> >> Hi Luis，the numa_balancing_promote_rate_limit_MBps from commit 1db91dd846e0 >> “memory tiering: rate limit NUMA migration throughput”only on >> linux-next（from mm repo）， >> >> 1）only send sysctl_numa_balancing changes based on your branch >> or >> >> 2）queued this patch from mm repo if no objection， Cc'ed Andrew >> >> Which one do your like, or other options, thanks. > 2) as that would give more testing to the new code as well. We can deal > with merge conflicts on my tree later. Thanks Luis. Hi Andrew, could you help to pick it up to your tree :) > > Luis > .