From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jared Hulbert" Subject: Re: [patch] ext2: xip check fix Date: Thu, 6 Dec 2007 19:22:25 -0800 Message-ID: <6934efce0712061922j682cee55pc1d5d079465f4849@mail.gmail.com> References: <20071204042628.GA26636@wotan.suse.de> <20071206101848.GC25202@wotan.suse.de> <4757CDD4.5090606@de.ibm.com> <200712061211.49443.rob@landley.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: carsteno@de.ibm.com, "Nick Piggin" , "Christian Borntraeger" , "Linux Kernel Mailing List" , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" , "Andrew Morton" , "Jens Axboe" To: "Rob Landley" Return-path: Received: from wa-out-1112.google.com ([209.85.146.177]:65078 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752944AbXLGDW0 (ORCPT ); Thu, 6 Dec 2007 22:22:26 -0500 Received: by wa-out-1112.google.com with SMTP id v27so1109838wah for ; Thu, 06 Dec 2007 19:22:26 -0800 (PST) In-Reply-To: <200712061211.49443.rob@landley.net> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > > I have'nt looked at it yet. I do appreciate it, I think it might > > broaden the user-base of this feature which is up to now s390 only due > > to the fact that the flash memory extensions have not been implemented > > (yet?). And it enables testing xip on other platforms. The patch is on > > my must-read list. > > query: which feature is currently s390 only? (Execute In Place?) I think so. The filemap_xip.c functionality doesn't work for Flash memory yet. Flash memory doesn't have struct pages to back it up with which this stuff depends on.