From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jared Hulbert" Subject: Re: [patch] ext2: xip check fix Date: Fri, 7 Dec 2007 01:52:15 -0800 Message-ID: <6934efce0712070152w70921c1od4ecfa15ce6270a0@mail.gmail.com> References: <20071204042628.GA26636@wotan.suse.de> <20071206101848.GC25202@wotan.suse.de> <4757CDD4.5090606@de.ibm.com> <200712061211.49443.rob@landley.net> <6934efce0712061922j682cee55pc1d5d079465f4849@mail.gmail.com> <47590B7E.5040608@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Rob Landley" , "Nick Piggin" , "Christian Borntraeger" , "Linux Kernel Mailing List" , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" , "Andrew Morton" , "Jens Axboe" To: carsteno@de.ibm.com Return-path: Received: from wa-out-1112.google.com ([209.85.146.183]:58263 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbXLGJwQ (ORCPT ); Fri, 7 Dec 2007 04:52:16 -0500 Received: by wa-out-1112.google.com with SMTP id v27so1363523wah for ; Fri, 07 Dec 2007 01:52:16 -0800 (PST) In-Reply-To: <47590B7E.5040608@de.ibm.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > > I think so. The filemap_xip.c functionality doesn't work for Flash > > memory yet. Flash memory doesn't have struct pages to back it up with > > which this stuff depends on. > > Struct page is not the major issue. The primary problem is writing to > the media (and I am not a flash expert at all, just relaying here): > For some period of time, the flash memory is not usable and thus we > need to make sure we can nuke the page table entries that we have in > userland page tables. For that, we need a callback from the device so > that it can ask to get its references back. Oh, and a put_xip_page > counterpart to get_xip_page, so that the driver knows when it's safe > to erase. Well... That's the biggest/hardest problem, yes. But not the first. First we got to tackle the easy read only case, which doesn't require any of that unpleasantness, yet which is used in a bunch of out of tree hacks.